Calls to get_fixed_ip are not implemented when using neutron

Bug #1269060 reported by Brent Eagles
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Invalid
Wishlist
Unassigned
neutron
Invalid
High
Unassigned

Bug Description

The get_fixed_ip() the nova.network.neutronv2.api module is not implemented.

Revision history for this message
Gary Kotton (garyk) wrote :

Please see the comment here:

    def get_fixed_ip(self, context, id):
        """Return a fixed ip."""
        # NOTE(vish): This is no longer used but can't be removed until
        # we major version the network_rpcapi to 2.0.
        fixed = self.db.fixed_ip_get(context, id)
        return jsonutils.to_primitive(fixed)

Is this still relevant?

Changed in nova:
status: New → Incomplete
Revision history for this message
Brent Eagles (beagles) wrote :

Good question. Considering the RPC API only used internally and is no longer used, I'd say no. Ideally, we would add a comment to neutronv2/api.py. Perhaps it would be best to make a "mondo" comment at the top of the file that lists the deliberately unimplemented methods and why.

Revision history for this message
Brent Eagles (beagles) wrote :

I was incorrect in my last statement. The comment indicated above exists in code that is not used by the nova-network API implementation and is implemented and still in use. This should be implemented.

Changed in nova:
status: Incomplete → New
Kyle Mestery (mestery)
tags: added: neutron-nova-parity
Changed in neutron:
status: New → Confirmed
importance: Undecided → High
Changed in neutron:
assignee: nobody → Eugene Nikanorov (enikanorov)
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → juno-1
Changed in nova:
assignee: nobody → Eugene Nikanorov (enikanorov)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/97101

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
Chris Behrens (cbehrens) wrote :

I do not see any place where this is used for neutron. The only reference to this that I can find is:

1219 if utils.is_neutron():
1220 fixed_vm_uuid = floating_ip['instance']['uuid']
1221 if fixed_vm_uuid is not None:
1222 ec2_id = ec2utils.id_to_ec2_inst_id(fixed_vm_uuid)
1223 else:
1224 fixed_id = floating_ip['fixed_ip_id']
1225 fixed = self.network_api.get_fixed_ip(context, fixed_id)
                                         ^^^^^^^^^^^^^^^^^^^^^^^^
1226 if fixed['instance_uuid'] is not None:
1227 ec2_id = ec2utils.id_to_ec2_inst_id(fixed['instance_uui

Revision history for this message
Eugene Nikanorov (enikanorov) wrote :

Yep, exactly, so I'm confused about what is expected and how to test it.

Changed in nova:
status: In Progress → Incomplete
Changed in neutron:
status: Confirmed → Incomplete
Kyle Mestery (mestery)
Changed in neutron:
milestone: juno-1 → juno-2
Kyle Mestery (mestery)
Changed in neutron:
milestone: juno-2 → none
Brent Eagles (beagles)
tags: added: neutron
removed: neutron-nova-parity
Sean Dague (sdague)
Changed in nova:
importance: Undecided → Wishlist
status: Incomplete → Confirmed
Revision history for this message
Marios Andreou (marios-b) wrote :

so grep doesn't show me any invocation of 'get_fixed_ip' on the neutron side - is there in fact anything to be done there?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Joe Gordon (<email address hidden>) on branch: master
Review: https://review.openstack.org/97101
Reason: Patch is stalled waiting for the author, looks like this has been abandoned. Feel free to restore.

Revision history for this message
Eugene Nikanorov (enikanorov) wrote :

Invalid for neutron.
Apparently get_fixed_ip() is not needed in nova as well.

Changed in neutron:
status: Incomplete → Invalid
Changed in nova:
assignee: Eugene Nikanorov (enikanorov) → nobody
Changed in neutron:
assignee: Eugene Nikanorov (enikanorov) → nobody
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :
Changed in nova:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers