request_spec[instance_properties] mismatches

[hougangliu]

When boot VM with '--num-instances', the param "request_spec['instance_properties']" that schedule_run_instance gets will be only the first instance's properties of request_spec.get('instance_uuids'), thus like request_spec['instance_properties']['instance_uuid'] , request_spec['instance_properties']['hostname'] and so on are all just the properties of the first VM.

Furthermore, if one of the VMs booting with '--num-instances' reschedules, request_spec['instance_properties'] is still for the first VM. Thus, using the data from request_spec['instance_properties'] is mistake, like instance_uuid = instance_properties.get('uuid') in filter_scheduler.py:def _populate_retry().

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/89757

[John Garbutt (johngarbutt)]

We use milestones only at the very end of the milestone to track bugs that should block the release of the milestone. Please use tags not milestones to track bugs, try things like: my_bug_topic_milestone_name

[Sean Dague (sdague)]

Patch is still active as of today

[Andrew Laski (alaski)]

I disagree that this is a bug. I think instance_properties should be stripped to only include information that is common between multiple instances. Even better would be to strip it down to only include what the scheduler is currently using. That appears to be 'launch_index', 'project_id', 'os_type', 'root_gb', 'ephemeral_gb', 'memory_mb', 'vcpus', 'vm_state', 'task_state'.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/89757
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Davanum Srinivas (DIMS) (dims-v)]

Removing "In Progress" status and assignee as change is abandoned.

[Andrew Laski (alaski)]

Anything that would vary between instances in a request like this is being removed from the request spec sent to the scheduler. The scheduler should not care about the specific instances being scheduled, only the requested resources that the instance needs from a compute.