| 2014-01-10 03:49:44 |
lizheming |
description |
In nova/utils.py, a func use the "type" method to determine the type. It's bertter to use the "isinstance" method instead.
The code is:
def convert_version_to_int(version):
try:
if type(version) == str:
version = convert_version_to_tuple(version)
if type(version) == tuple:
return reduce(lambda x, y: (x * 1000) + y, version)
except Exception:
raise exception.NovaException(message="Hypervisor version invalid.")
. |
In nova/utils.py, a func use the "type" method to determine the type. It's bertter to use the "isinstance" method instead.
The code is:
def convert_version_to_int(version):
try:
if type(version) == str:
version = convert_version_to_tuple(version)
if type(version) == tuple:
return reduce(lambda x, y: (x * 1000) + y, version)
except Exception:
raise exception.NovaException(message="Hypervisor version invalid.")
this bug is fixed in glance:
https://review.openstack.org/#/c/65611/4 |
|
