bad english in string: "Disabled reason contains invalid characters or is too long"

Bug #1266620 reported by Tom Fifield
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
lizheming
openstack i18n
Fix Released
Undecided
Hemanth Nakkina

Bug Description

This string: "Disabled reason contains invalid characters or is too long"

found in
nova/api/openstack/compute/contrib/services.py:177, nova/api/openstack/compute/plugins/v3/services.py:159

should be fixed.

From the spanish translation team:
Se recomienda que esta cadena sea reestructurada en su versión original, particularmente "Disabled reason".

Essentially, the string isn't the best English and should be re-written so it can be translated properly - particularly the use of "Disabled reason".

Revision history for this message
Tom Fifield (fifieldt) wrote :
summary: - translation problem in nova: "Disabled reason"
+ bad english in string: "Disabled reason"
summary: - bad english in string: "Disabled reason"
+ bad english in string: "Disabled reason contains invalid characters or
+ is too long"
Changed in openstack-i18n:
status: New → Confirmed
tags: added: i18n
Revision history for this message
Tom Fifield (fifieldt) wrote :

Looking at the code, two suggestions

1) either "Disabled reason" should be "disabled_reason", or
2) the string should be changed to: "The string containing the reason for disabling the service contains invalid characters or is too long."

Joe Gordon (jogo)
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
tags: added: low-hanging-fruit
Changed in nova:
status: Confirmed → Triaged
Changed in openstack-i18n:
assignee: nobody → chandankumar (chandankumar-093047)
lizheming (lizheming-li)
Changed in nova:
assignee: nobody → lizheming (lizheming-li)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/66313

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/66081
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c167db9536c2d1ad22ac7463d448d092ca5b530e
Submitter: Jenkins
Branch: master

commit c167db9536c2d1ad22ac7463d448d092ca5b530e
Author: Joe Gordon <email address hidden>
Date: Fri Jan 10 15:14:54 2014 -0800

    Improve error message in services API

    The awkward grammar of the original error message was making i18n
    translations hard.

    Change-Id: I2ff98f2d3585d5f1ccf0deb552e73c452393f124
    Closes-Bug: #1266620

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Changed in openstack-i18n:
assignee: chandankumar (chandankumar-093047) → nobody
Changed in openstack-i18n:
status: Confirmed → In Progress
Changed in openstack-i18n:
assignee: nobody → Hemanth Nakkina (hemanth-n)
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
Tom Fifield (fifieldt)
Changed in openstack-i18n:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.