Wrong variable names " addFixedIp" and "networkId" in multinic-add-fixed-ip-req.json

Bug #1265716 reported by Shuangtai Tian
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Shuangtai Tian

Bug Description

{
   "addFixedIp":{
   "networkId": 1
}
}

the variable names should be "add_fixed_ip" and "network_id"
those are forgot to change in the abaadf09ed86ef68(Adds V3 API samples for cells and multinic)

please see:
https://github.com/openstack/nova/blob/master/nova/tests/integrated/v3/api_samples/os-multinic/multinic-add-fixed-ip-req.json.tpl#L2

https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/plugins/v3/multinic.py#L54

Changed in nova:
assignee: nobody → Shuangtai Tian (shuangtai-tian)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64787

Changed in nova:
status: New → In Progress
Changed in nova:
milestone: none → icehouse-2
importance: Undecided → Low
Changed in nova:
importance: Low → Medium
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-2 → icehouse-3
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/64787
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1b0d1bebaeb0e4a748289438141e195852fd2b33
Submitter: Jenkins
Branch: master

commit 1b0d1bebaeb0e4a748289438141e195852fd2b33
Author: Shuangtai Tian <email address hidden>
Date: Fri Jan 3 14:08:11 2014 +0800

    Fix a bug in v3 API doc

    This patch changes the wrong variable names 'addFixedIp' and 'networkId',
    which were not used in V3 multinic API. We use 'add_fixed_ip' and
    'network_id' in V3 multinic API.

    Closes-bug: #1265716

    Change-Id: I0c91764603d941df6d011a3b1266eb354c0bc54f

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.