VMware: unnecesary session termination

[Gary Kotton]

In some cases, the session with the VC is terminated and restarted again. This can happen for example when the user does:
nova list (and there are no running VMs)
In addition to the restart of the session the operation also waits 2 seconds.

[Gary Kotton (garyk)]

This issue causes failures in the CI

[Gary Kotton (garyk)]

https://review.openstack.org/#/c/64598/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/64598
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=55296828a7d7a03736a21d846da15571ca22ec9e
Submitter: Jenkins
Branch: master

commit 55296828a7d7a03736a21d846da15571ca22ec9e
Author: Gary Kotton <email address hidden>
Date: Tue Dec 31 23:40:29 2013 -0800

    VMware: unnecessary session reconnection

    An error FAULT_NOT_AUTHENTICATED could imply that there is a problem
    with the backend or that no values were found (for example there are
    no running VMS). In the latter case the connection should not
    be restarted.

    The patch also ensures that the session is restarted if there are
    connection issues.

    This issue occasionally causes CI issues with minesweeper.

    Closes-bug: #1265512

    Co-authored-by: Shawn Harsock <email address hidden>

    Change-Id: Ibfa83d0b5b93680890aad8c88c041fa344765448

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/67667

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/67667
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bb7a4703c6e990fac73997e093a3766756ebd71f
Submitter: Jenkins
Branch: stable/havana

commit bb7a4703c6e990fac73997e093a3766756ebd71f
Author: Gary Kotton <email address hidden>
Date: Tue Dec 31 23:40:29 2013 -0800

    VMware: unnecessary session reconnection

    An error FAULT_NOT_AUTHENTICATED could imply that there is a problem
    with the backend or that no values were found (for example there are
    no running VMS). In the latter case the connection should not
    be restarted.

    The patch also ensures that the session is restarted if there are
    connection issues.

    This issue occasionally causes CI issues with minesweeper.

    Closes-bug: #1265512

    Co-authored-by: Shawn Harsock <email address hidden>

    Conflicts:

     nova/tests/virt/vmwareapi/test_vmwareapi.py

    Change-Id: Ibfa83d0b5b93680890aad8c88c041fa344765448
    (cherry picked from commit 55296828a7d7a03736a21d846da15571ca22ec9e)