ignored VimFaultException showing up in nova unit test logs

[Matt Riedemann]

This started showing up recently in the nova unit tests:

Exception nova.virt.vmwareapi.error_util.VimFaultException: VimFaultException() in <bound method VMwareAPISession.__del__ of <nova.virt.vmwareapi.driver.VMwareAPISession object at 0x11bb66cc>> ignored
Exception nova.virt.vmwareapi.error_util.VimFaultException: VimFaultException() in <bound method VMwareAPISession.__del__ of <nova.virt.vmwareapi.driver.VMwareAPISession object at 0x127d868c>> ignored
Exception nova.virt.vmwareapi.error_util.VimFaultException: VimFaultException() in <bound method VMwareAPISession.__del__ of <nova.virt.vmwareapi.driver.VMwareAPISession object at 0x118b390c>> ignored

It doesn't cause a failure, but it's ugly and should be cleaned up.

[Shawn Hartsock (hartsock)]

Looks like the destructor is throwing something from the Logout method. That's probably something trivial to fix.

[Gary Kotton (garyk)]

Hi,
I ma unable to reproduce this with master:

gkotton@openstack:~/nova$ tox
py26 create: /home/gkotton/nova/.tox/py26
ERROR: InterpreterNotFound: python2.6
py27 develop-inst-nodeps: /home/gkotton/nova
py27 runtests: commands[0] | python setup.py test --slowest --testr-args=
running test
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-160} \
${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --list
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-160} \
${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmphFdy35
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-160} \
${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmpNHjZBv
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-160} \
${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmpNJcdWX
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-160} \
${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmpVNZqv6
Ran 10051 (+8922) tests in 711.033s (+675.827s)
PASSED (id=1164, skips=11)
Slowest Tests
Test id Runtime (s)
-------------------------------------------------------------------------------------------------------- -----------
nova.tests.integrated.v3.test_hide_server_addresses.ServersSampleHideAddressesJsonTest.test_servers_list 43.311
nova.tests.integrated.test_multiprocess_api.MultiprocessWSGITest.test_killed_worker_recover 42.130
nova.tests.integrated.v3.test_deferred_delete.DeferredDeleteSampleXmlTests.test_force_delete 27.586
nova.tests.integrated.v3.test_flavors.FlavorsSampleJsonTest.test_flavors_get 26.525
nova.tests.virt.libvirt.test_libvirt.LibvirtConnTestCase.test_get_guest_cpu_config_host_model_old 26.148
nova.tests.integrated.v3.test_quota_class_sets.QuotaClassesSampleJsonTests.test_update_quota_classes 22.885
nova.tests.integrated.test_multiprocess_api.MultiprocessWSGITest.test_terminate_sigterm 20.466
nova.tests.integrated.test_api_samples.ShelveXmlTest.test_shelve_offload 19.615
nova.tests.test_availability_zones.AvailabilityZoneTestCases.test_update_host_availability_zone 19.152
nova.tests.integrated.v3.test_flavor_rxtx.FlavorRxtxXmlTest.test_flavors_rxtx_create 18.455
py33 create: /home/gkotton/nova/.tox/py33
ERROR: InterpreterNotFound: python3.3
pep8 develop-inst-nodeps: /home/gkotton/nova
pep8 runtests: commands[0] | flake8
pep8 runtests: commands[1] | /home/gkotton/nova/tools/config/check_uptodate.sh
____________________________________________________________________________________________________...

[Matt Riedemann (mriedem)]

Hmm, I just ran it like this:

tox -r -e py27

I'll keep an eye out for it.

[Matt Riedemann (mriedem)]

Patch to remove __del__ usage is here: https://review.openstack.org/#/c/75186/

[Shawn Hartsock (hartsock)]

After this https://review.openstack.org/#/c/75186/ we need this: https://review.openstack.org/#/c/75262/

Otherwise we will have dangling sessions in vCenter/ESX ...

Fixes dangling sessions left open and will help users clean up their vCenters.
 https://review.openstack.org/#/c/75262/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/75186
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b28530ce83302dacae90c385c5431fb1a758ef0a
Submitter: Jenkins
Branch: master

commit b28530ce83302dacae90c385c5431fb1a758ef0a
Author: Dan Smith <email address hidden>
Date: Thu Feb 20 13:03:12 2014 -0800

    Remove __del__ usage in vmwareapi driver

    The vmwareapi driver uses __del__ in an inappropriate way, which
    causes spurious errors to be displayed at inconvenient times. The
    python docs clearly detail the caveats of using __del__ (and even
    provide a big red warning). This removes the offending code, which
    can't work reliably anyway.

    Closes-bug: 1262288
    Change-Id: I50acb4f1e85650f4c6dffe1a1d25842601be96bf

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/80434