xenapi: server gets deleted under certain live-migrate error conditions

[John Garbutt]

Any errors after the XenServer migrate command completes currently can cause the users VM to be deleted.

While there should be some cleanup performed, deleting the VM does not make sense for the XenAPI driver.

[John Garbutt (johngarbutt)]

https://review.openstack.org/#/c/62855

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/62855
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d54041f0b4763c00f661088f113e26e38c747730
Submitter: Jenkins
Branch: master

commit d54041f0b4763c00f661088f113e26e38c747730
Author: John Garbutt <email address hidden>
Date: Wed Dec 18 11:44:35 2013 +0000

    xenapi: stop server destroy on live_migrate errors

    Currently where there are errors after live-migration has completed, the
    server is destroyed, which for XenAPI driver, means the server no longer
    exists, because XenServer has already deleted the source VM.

    Closes-Bug: #1262206
    Change-Id: I7f827f5d972da26f5d1edae7a22fb45a1f5dd6ca