ConfigDrive metadata is incorrectly generated on Windows

Bug #1261585 reported by Alessandro Pilotti on 2013-12-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Low
Alessandro Pilotti
Havana
Undecided
Unassigned

Bug Description

Files must be written with "wb" instead of "w" in order to support multiple platforms:

https://github.com/openstack/nova/blob/b823db737855149ba847e5b19df9232f109f6001/nova/virt/configdrive.py#L92

tags: added: hyper-v
ugvddm (271025598-9) on 2013-12-17
Changed in nova:
assignee: nobody → ugvddm (271025598-9)
assignee: ugvddm (271025598-9) → nobody
Joe Gordon (jogo) on 2013-12-17
Changed in nova:
status: New → Triaged
Changed in nova:
assignee: nobody → Abhishek Chanda (abhishek-i)
tags: added: low-hanging-fruit

Fix proposed to branch: master
Review: https://review.openstack.org/62564

Changed in nova:
status: Triaged → In Progress
Changed in nova:
importance: Undecided → Low

Reviewed: https://review.openstack.org/62502
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1fc9eafab43accc127044351106983e2cb215520
Submitter: Jenkins
Branch: master

commit 1fc9eafab43accc127044351106983e2cb215520
Author: Alessandro Pilotti <email address hidden>
Date: Tue Dec 17 02:05:11 2013 +0200

    Fixes ConfigDrive bug on Windows

    Files must be written specifying "wb" instead of "w"
    to support binary files on both Windows and Linux.

    Change-Id: I069845136df4a11b54c931a71575ca3efb9bc6d0
    Closes-Bug: #1261585

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
assignee: Abhishek Chanda (abhishek-i) → nobody
Changed in nova:
assignee: nobody → Alessandro Pilotti (alexpilotti)
tags: added: havana-backport-potential
Changed in nova:
milestone: none → icehouse-2
Thierry Carrez (ttx) on 2014-01-22
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in nova:
milestone: icehouse-2 → 2014.1

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/110706

Change abandoned by Petrut Lucian (<email address hidden>) on branch: stable/havana
Review: https://review.openstack.org/83361

Reviewed: https://review.openstack.org/110706
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fd45b41ba3963f475fa337d58afa983e9eb7ac43
Submitter: Jenkins
Branch: stable/havana

commit fd45b41ba3963f475fa337d58afa983e9eb7ac43
Author: Alessandro Pilotti <email address hidden>
Date: Tue Dec 17 02:05:11 2013 +0200

    Fixes ConfigDrive bug on Windows

    Files must be written specifying "wb" instead of "w"
    to support binary files on both Windows and Linux.

    Closes-Bug: #1261585

    (cherry-picked from commit 1fc9eafab43accc127044351106983e2cb215520)

    Change-Id: I069845136df4a11b54c931a71575ca3efb9bc6d0

tags: added: in-stable-havana
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers