OpenStack Compute (nova)

ConfigDrive metadata is incorrectly generated on Windows

Bug #1261585 reported by Alessandro Pilotti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Alessandro Pilotti
OpenStack Compute (nova) 2014.1 "icehouse"
Havana
Fix Released
Undecided
Unassigned
OpenStack Compute (nova) 2013.2.4

Bug Description

Files must be written with "wb" instead of "w" in order to support multiple platforms:

https://github.com/openstack/nova/blob/b823db737855149ba847e5b19df9232f109f6001/nova/virt/configdrive.py#L92

Alessandro Pilotti (alexpilotti)
tags: added: hyper-v
ugvddm (271025598-9)
Changed in nova:
assignee: nobody → ugvddm (271025598-9)
assignee: ugvddm (271025598-9) → nobody
Joe Gordon (jogo)
Changed in nova:
status: New → Triaged
Abhishek Chanda (abhishek-i)
Changed in nova:
assignee: nobody → Abhishek Chanda (abhishek-i)
tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/62564

Changed in nova:
status: Triaged → In Progress
Abhishek Chanda (abhishek-i)
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/62502
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1fc9eafab43accc127044351106983e2cb215520
Submitter: Jenkins
Branch: master

commit 1fc9eafab43accc127044351106983e2cb215520
Author: Alessandro Pilotti <email address hidden>
Date: Tue Dec 17 02:05:11 2013 +0200

    Fixes ConfigDrive bug on Windows

    Files must be written specifying "wb" instead of "w"
    to support binary files on both Windows and Linux.

    Change-Id: I069845136df4a11b54c931a71575ca3efb9bc6d0
    Closes-Bug: #1261585

Changed in nova:
status: In Progress → Fix Committed
Abhishek Chanda (abhishek-i)
Changed in nova:
assignee: Abhishek Chanda (abhishek-i) → nobody
Alessandro Pilotti (alexpilotti)
Changed in nova:
assignee: nobody → Alessandro Pilotti (alexpilotti)
Alessandro Pilotti (alexpilotti)
tags: added: havana-backport-potential
Russell Bryant (russellb)
Changed in nova:
milestone: none → icehouse-2
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/83361

Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-2 → 2014.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/110706

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/havana)

Change abandoned by Petrut Lucian (<email address hidden>) on branch: stable/havana
Review: https://review.openstack.org/83361

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/havana)

Reviewed: https://review.openstack.org/110706
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fd45b41ba3963f475fa337d58afa983e9eb7ac43
Submitter: Jenkins
Branch: stable/havana

commit fd45b41ba3963f475fa337d58afa983e9eb7ac43
Author: Alessandro Pilotti <email address hidden>
Date: Tue Dec 17 02:05:11 2013 +0200

    Fixes ConfigDrive bug on Windows

    Files must be written specifying "wb" instead of "w"
    to support binary files on both Windows and Linux.

    Closes-Bug: #1261585

    (cherry-picked from commit 1fc9eafab43accc127044351106983e2cb215520)

    Change-Id: I069845136df4a11b54c931a71575ca3efb9bc6d0

tags: added: in-stable-havana
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.