Nova Docker driver doesn't remove created network namespace

[Daniel Kuffner]

The Nova Docker driver doesn't remove the network namespace after machine has been destroyed.

Steps to reproduce:

1. Look up available network namespaces, on a fresh machine the list should be empty:
    $ ip netns show

2. Start a new docker container via nova
    $ nova boot --image busybox:latest test1

3. Look up available network namespaces:
    $ ip netns show
    5f6b61d44ae15a77b277ebbf422fe88f369f8cdbb81a64aa6ea4beaf110204a6

4. Destroy nova instance
    $ nova delete test1

5. Look up available network namespaces, the list must be empty but isn't
    $ ip netns show
    5f6b61d44ae15a77b277ebbf422fe88f369f8cdbb81a64aa6ea4beaf110204a6

The nova drive must remove this network namespaces on instance destroy by calling:

    ip netns delete $container_id

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/62183

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/62183
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d8145054b09ca422f064a5d936ac1a8ae596b266
Submitter: Jenkins
Branch: master

commit d8145054b09ca422f064a5d936ac1a8ae596b266
Author: Daniel Kuffner <email address hidden>
Date: Sat Dec 14 18:41:42 2013 +0100

    Nova Docker driver must remove network namespace

    The docker hypervisor creates for each container a network
    namespace which represents the nova network. This network
    namespace must be removed/destroyed when nova instance will
    be destroyed in order to cleanup the machine properly.

    Change-Id: I6fa306d06fb16f8ceddb06e22566974237082759
    Closes-Bug: 1261007