VMware: refactor volumeops._get_volume_uuid()

[Radoslav Gerganov]

Recently I have been doing some queries for extraConfig VM options and found that the most efficient way to retrieve a given property is to do:

session._call_method(vim_util, 'get_dynamic_property', vm_ref, 'VirtualMachine', 'config.extraConfig["some_prop_here"]')

Right now we ask for all extraConfig options and then we iterate over the result set to find a particular one.

[Shawn Hartsock (hartsock)]

Note: I see this as a low priority refactor for efficiency. That means the refactor should increase over all test coverage as a beneficial side-effect as well as demonstrate a more efficient algorithm (either by logical argument & mathematical proof or by test and measurements)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/72663

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/72663
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b48bd3c0cf1f4ccfada24a6aebc7ced308d44927
Submitter: Jenkins
Branch: master

commit b48bd3c0cf1f4ccfada24a6aebc7ced308d44927
Author: Radoslav Gerganov <email address hidden>
Date: Mon Feb 10 18:07:33 2014 +0200

    VMware: refactor _get_volume_uuid

    It is more efficient to ask vCenter for specific extraConfig property instead
    getting all properties and then manually searching the one which is
    needed.

    Closes-Bug: #1257726
    Change-Id: I4fc8399c9a8b6a141ac489e8fb92117ec03ca42f