invalid flavor marker leads to KeyError

[Andrew Laski]

2013-12-02 17:40:26.549 ERROR nova.exception [req-794c2928-31c5-406d-a1f2-8afc40bebf4e demo demo] Exception in string format operation
2013-12-02 17:40:26.549 TRACE nova.exception Traceback (most recent call last):
2013-12-02 17:40:26.549 TRACE nova.exception File "/opt/stack/nova/nova/exception.py", line 120, in __init__
2013-12-02 17:40:26.549 TRACE nova.exception message = self.msg_fmt % kwargs
2013-12-02 17:40:26.549 TRACE nova.exception KeyError: u'marker'
2013-12-02 17:40:26.549 TRACE nova.exception
2013-12-02 17:40:26.550 ERROR nova.exception [req-794c2928-31c5-406d-a1f2-8afc40bebf4e demo demo] code: 404

Because the query result from checking if the marker exists overwrites the marker being looked for, the exception can't be built properly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/59500

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/59500
Committed: http://github.com/openstack/nova/commit/4dd6c368e75183d8d3aed4e9f98d928e8f3a21b2
Submitter: Jenkins
Branch: master

commit 4dd6c368e75183d8d3aed4e9f98d928e8f3a21b2
Author: Andrew Laski <email address hidden>
Date: Mon Dec 2 12:47:24 2013 -0500

    Don't overwrite marker when checking if it exists

    Checking for the existence of a marker overwrote which marker was being
    checked for. The string representation of the marker needs to be
    retained so that a proper exception can be built. So a new variable is
    introduced which can be used to check for marker existence.

    Change-Id: I81cfdceca3921c364cdeeccd24add14a6b1d0fd4
    Closes-bug: 1257008