XenAPI: no such option: default_os_type

[Bob Ball]

Following trace occurs due to incomplete change I2e9f720ddce284fc112d6a5651fd277e6e31a17a

TRACE nova.compute.manager Traceback (most recent call last):
TRACE nova.compute.manager File "/opt/stack/nova/nova/compute/manager.py", line 310, in decorated_function
TRACE nova.compute.manager *args, **kwargs)
TRACE nova.compute.manager File "/opt/stack/nova/nova/compute/manager.py", line 2434, in snapshot_instance
TRACE nova.compute.manager task_states.IMAGE_SNAPSHOT)
TRACE nova.compute.manager File "/opt/stack/nova/nova/compute/manager.py", line 2465, in _snapshot_instance
TRACE nova.compute.manager update_task_state)
TRACE nova.compute.manager File "/opt/stack/nova/nova/virt/xenapi/driver.py", line 271, in snapshot
TRACE nova.compute.manager self._vmops.snapshot(context, instance, image_id, update_task_state)
TRACE nova.compute.manager File "/opt/stack/nova/nova/virt/xenapi/vmops.py", line 734, in snapshot
TRACE nova.compute.manager image_id)
TRACE nova.compute.manager File "/opt/stack/nova/nova/virt/xenapi/image/glance.py", line 62, in upload_image
TRACE nova.compute.manager props['os_type'] = instance['os_type'] or CONF.default_os_type
TRACE nova.compute.manager File "/opt/stack/oslo.config/oslo/config/cfg.py", line 1688, in __getattr__
TRACE nova.compute.manager raise NoSuchOptError(name)
TRACE nova.compute.manager NoSuchOptError: no such option: default_os_type

[Bob Ball (bob-ball)]

Impact is that much of XenAPI is broken in some configurations

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/57431

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/57431
Committed: http://github.com/openstack/nova/commit/32f1b413ddfaf58703d9f6d69a1fc44e6c17d60d
Submitter: Jenkins
Branch: master

commit 32f1b413ddfaf58703d9f6d69a1fc44e6c17d60d
Author: Bob Ball <email address hidden>
Date: Fri Nov 22 16:32:11 2013 +0000

    XenAPI: Fix config section usage

    Change I2e9f720ddce284fc112d6a5651fd277e6e31a17a introduced xenserver
    sections but a couple of CONF variables were not updated to use the
    new sections.

    Fixed the few remaining options and add unit tests to ensure they are
    caught in future.

    The unit tests highlighted that the functions behaved strangely in
    the cases where the default was being provided - so updated to be
    clear about getting the default.

    Closes-bug: 1253064

    Change-Id: Ic538069cd087aa3cdc0a1f7fdb94820d5d3b22b1