fix for LP #1240905 has a further bug

Bug #1250135 reported by Tom Hancock
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Unassigned
Havana
Fix Released
Undecided
Unassigned

Bug Description

Commit id b2e64e379835f57128e66f507438130eda716814 is a fix for LP #1240905
but it it has a bug in the fix that causes conn.domainEventRegisterAny() to be called on each
call to _get_connection() due to incorrect indentation of the domainEventRegisterAny section.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/55866
Committed: http://github.com/openstack/nova/commit/755f6194e29c8e3daf6fd64a59dc2be4c81b1f0d
Submitter: Jenkins
Branch: master

commit 755f6194e29c8e3daf6fd64a59dc2be4c81b1f0d
Author: Tom Hancock <email address hidden>
Date: Mon Nov 11 14:23:24 2013 +0000

    domainEventRegisterAny called too often

    Changeid I090765802bfe443440f16722bc7c43b6280fe56a fixes
    bug #1240905 but introduced a bug whereby domainEventRegisterAny
    is called on every call to _get_connection.

    Change-Id: Ifafc6a4c172b1521d62988ccbb3a2f51a95e323f
    Fixes: bug #1250135

Changed in nova:
status: New → Fix Committed
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/112420

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/havana)

Reviewed: https://review.openstack.org/112420
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fd5b2bd67f9506fb83cc66c4dacf410901e41208
Submitter: Jenkins
Branch: stable/havana

commit fd5b2bd67f9506fb83cc66c4dacf410901e41208
Author: Tom Hancock <email address hidden>
Date: Mon Nov 11 14:23:24 2013 +0000

    domainEventRegisterAny called too often

    Changeid I090765802bfe443440f16722bc7c43b6280fe56a fixes
    bug #1240905 but introduced a bug whereby domainEventRegisterAny
    is called on every call to _get_connection.

    Conflicts:
            nova/virt/libvirt/driver.py

    NOTE(mriedem): The conflict is due to the set_host_enabled
    code not being in stable/havana and we don't want to backport
    that for the threading fixes in this series.

    Change-Id: Ifafc6a4c172b1521d62988ccbb3a2f51a95e323f
    Fixes: bug #1250135
    (cherry picked from commit 755f6194e29c8e3daf6fd64a59dc2be4c81b1f0d)

tags: added: in-stable-havana
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.