encryptors module forces cert and scheduler services to depend on cinderclient

[Solly Ross]

When Nova Scheduler is installed via packstack as the only explicitly installed service on a particular node, it will fail to start. This is because it depends on the Python cinderclient library, which is not marked as a dependency in 'nova::scheduler' class in Packstack.

[Solly Ross (sross-7)]

See also: https://bugzilla.redhat.com/show_bug.cgi?id=1021405

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/54512
Committed: http://github.com/openstack/nova/commit/a3aeace9afd5c533f040452f33482fdb55d93927
Submitter: Jenkins
Branch: master

commit a3aeace9afd5c533f040452f33482fdb55d93927
Author: Xavier Queralt <email address hidden>
Date: Wed Oct 30 10:28:43 2013 +0100

    Pass volume_api to get_encryption_metadata

    The module encryptors was creating a volume API instance in the module
    scope which caused all the modules importing it to depend on
    cinderclient.

    This was affecting scheduler and cert services which at some point import
    the compute manager module only to access their config options. It makes
    no sense to force scheduler and cert services to require cinderclient.

    This patch makes the callers of get_encryption_metadata to pass the
    volume api object to this method to prevent this dependency.

    Closes-Bug: #1246103
    Change-Id: I9eb4ae3754fa2a5ac646560a62477d6ed672e272

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/54533

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/54533
Committed: http://github.com/openstack/nova/commit/ff67b463b139d7b6bb14033c12ab59c5afdde4c2
Submitter: Jenkins
Branch: stable/havana

commit ff67b463b139d7b6bb14033c12ab59c5afdde4c2
Author: Xavier Queralt <email address hidden>
Date: Wed Oct 30 10:28:43 2013 +0100

    Pass volume_api to get_encryption_metadata

    The module encryptors was creating a volume API instance in the module
    scope which caused all the modules importing it to depend on
    cinderclient.

    This was affecting scheduler and cert services which at some point import
    the compute manager module only to access their config options. It makes
    no sense to force scheduler and cert services to require cinderclient.

    This patch makes the callers of get_encryption_metadata to pass the
    volume api object to this method to prevent this dependency.

    Closes-Bug: #1246103
    Change-Id: I9eb4ae3754fa2a5ac646560a62477d6ed672e272
    (cherry picked from commit a3aeace9afd5c533f040452f33482fdb55d93927)