Flavors v2,v3/flavors/​{flavor_id}​ API should not return deleted flavor

[Tiago Mello]

Currently, if you pass a flavor_id of a deleted for the v2/flavors/​{flavor_id}​ API call, it will return the flavor even though it has been deleted. The API shouldn't return a deleted flavor unless it is explicity requested for with any other parameter.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/54401

[Christopher Yeoh (cyeoh-0)]

I don't think this is a straigtforward fix.

Deleted flavors may still be in use by running instances so its quite a valid request to retreive information about them. At the very least we need the ability to specify that we want to show information for a deleted flavor.

Its unclear whether this is intentional behavior or not (being able to show deleted flavors) so I think its probably worth bringing up on the mailing list to see if we should change it for V2.

For V3 I think we need some wider changes to the flavors API, and am planning on bringing it up at summit

[Tracy Jones (tjones-i)]

this is an old bug with only an abandoned review. please reopen if you intend to fix

[Sean Dague (sdague)]

The deleted flavor information should be stored in the instance system metadata, so it should be fine.