Nova Docker driver cannot destroy instance because context variable is missing

[Daniel Kuffner]

Nova Docker driver cannot destroy instance because context variable is missing.

https://github.com/openstack/nova/blob/master/nova/virt/docker/driver.py#L318

def destroy(self, instance, network_info, block_device_info=None,
                destroy_disks=True):

must be

def destroy(self, instance, network_info, block_device_info=None,
                destroy_disks=True, context=None):

to make the docker driver full functional

Steps to reproduce:
1. (Horizon) Create multiple docker container
2. Wait until all container are up and running (in my case I had even failing container because of a setup issue).
3. (Horizon) Select all container and press terminate instance

Result some container are not deleted/removed from docker. The instances will still be displayed in horizon.

Unfortunately I have currently no setup to provide the stack trace. The stace trace clearly said that method destroy cannot be called since variable "context" isn't expected.

[Daniel Kuffner (daniel-kuffner)]

Pull request: https://github.com/openstack/nova/pull/28

[Andrew Laski (alaski)]

It would be helpful if you could document what issue is being caused by this.