NoopQuotaDriver returns usages incorrect format

Bug #1244842 reported by Rick Harris on 2013-10-26
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Medium
Rick Harris
Havana
Medium
Yang Yu

Bug Description

get_project_usages and get_user_usages should return a dictionary instead of an integer.

The form should be dict(limit=-1).

Associated traceback: http://paste.openstack.org/show/49790/

Rick Harris (rconradharris) wrote :

Fix should be backported to Havana.

Changed in nova:
assignee: nobody → Rick Harris (rconradharris)
status: New → In Progress
Rick Harris (rconradharris) wrote :

Typo, affected functions are get_user_quotas and get_project_quotas.

Reviewed: https://review.openstack.org/53977
Committed: http://github.com/openstack/nova/commit/711a12b4029cd1544d26d147d8a67e110e056124
Submitter: Jenkins
Branch: master

commit 711a12b4029cd1544d26d147d8a67e110e056124
Author: Rick Harris <email address hidden>
Date: Sat Oct 26 01:07:28 2013 +0000

    Fix `NoopQuotaDriver.get_(project|user)_quotas` format

    The quota API extension expects `get_project_quotas` and `get_user_quotas` to
    return a dictionary where the value is another dictionary with a `limit` key.

    The `DbQuotaDriver` adhered to this spec, but the `NoopQuotaDriver` didn't.

    This fixes the `NoopQuotaDriver` to return the results in the correct format.

    Fixes bug 1244842

    Change-Id: Iea274dab1c3f10c3cb0a2815f431e15b4d4934b1

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx) on 2013-12-04
Changed in nova:
status: Fix Committed → Fix Released

Reviewed: https://review.openstack.org/55557
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a52043858434cab74ccf92549feb19ecb3264499
Submitter: Jenkins
Branch: stable/havana

commit a52043858434cab74ccf92549feb19ecb3264499
Author: Rick Harris <email address hidden>
Date: Sat Oct 26 01:07:28 2013 +0000

    Fix `NoopQuotaDriver.get_(project|user)_quotas` format

    The quota API extension expects `get_project_quotas` and `get_user_quotas` to
    return a dictionary where the value is another dictionary with a `limit` key.

    The `DbQuotaDriver` adhered to this spec, but the `NoopQuotaDriver` didn't.

    This fixes the `NoopQuotaDriver` to return the results in the correct format.

    Fixes bug 1244842

    Change-Id: Iea274dab1c3f10c3cb0a2815f431e15b4d4934b1
    (cherry picked from commit 711a12b4029cd1544d26d147d8a67e110e056124)

tags: added: in-stable-havana
Alan Pevec (apevec) on 2014-02-13
Changed in nova:
importance: Undecided → Medium
tags: removed: in-stable-havana
Thierry Carrez (ttx) on 2014-04-17
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers