VMware: move file name handling to utility methods

Bug #1240653 reported by Tracy Jones
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Won't Fix
Low
Unassigned

Bug Description

It's tempting to use os.path to create proper file names in nova-compute. However for the vmware driver this breaks if nova-compute is run on windows. We should use utility methods to create the filename/path so that people don't need to know to not to use os.path.

Another option is to use os_posix.path()

Tracy Jones (tjones-i)
Changed in nova:
assignee: nobody → Tracy Jones (tjones-i)
Revision history for this message
Tracy Jones (tjones-i) wrote :

for example -

import posixpath
posixpath.join('a', 'b')

Changed in nova:
importance: Undecided → Low
Mathew Odden (locke105)
tags: added: vmware
Tracy Jones (tjones-i)
tags: added: low-hanging-fruit
Changed in nova:
assignee: Tracy Jones (tjones-i) → nobody
Gary Kotton (garyk)
Changed in nova:
status: New → Confirmed
Kai Tong (tongkai)
Changed in nova:
assignee: nobody → Kai Tong (tongkai)
Revision history for this message
Tracy Jones (tjones-i) wrote :

Kai - can you consider fixing this so that it is clear when an ESX path is needed vs a Nova path?

i.e.

esxPath(...)

vs

novaPath(...)

Kai Tong (tongkai)
Changed in nova:
assignee: Kai Tong (tongkai) → nobody
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

Will work on this during the OpenStack upstream training of the summit.

Changed in nova:
assignee: nobody → Markus Zoeller (mzoeller)
Changed in nova:
assignee: Markus Zoeller (mzoeller) → nobody
Changed in nova:
assignee: nobody → pradeep kumar singh (pradeep-singh-u)
Changed in nova:
assignee: pradeep kumar singh (pradeep-singh-u) → nobody
Revision history for this message
Gary Kotton (garyk) wrote :

This has been addressed in the oslo vmware library.

Changed in nova:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.