boto version checking in test cases is not backwards compatible

Bug #1239220 reported by James Page
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Davanum Srinivas (DIMS)
Grizzly
Fix Released
Medium
Adam Gandelman
Havana
Fix Released
Medium
Dirk Mueller

Bug Description

The changes in commit:

  https://github.com/openstack/nova/commit/7161c62c22ebe609ecaf7e01d2feae473d01495a

Introduced version checking for boto 2.14; however string comparison is not effective for version checking as

'2.9.6' >= '2.14' == true

Resulting in older boto versions (as found in saucy) trying to test with the 2.14 code.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :
Changed in nova:
status: New → In Progress
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
Changed in nova:
importance: Undecided → Medium
Thierry Carrez (ttx)
tags: added: havana-backport-potential
removed: havana-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/51426
Committed: http://github.com/openstack/nova/commit/eaf5636544a9b2ae1e87f74d0cdb989f8a41b008
Submitter: Jenkins
Branch: master

commit eaf5636544a9b2ae1e87f74d0cdb989f8a41b008
Author: Davanum Srinivas <email address hidden>
Date: Sat Oct 12 21:49:34 2013 -0400

    Harden version checking for boto

    Simple string comparison is not effective for version checking.
    Let's switch to using pkg_resources.parse_version and compare
    the tuples. Per review feedback, enabling the code path for
    2.13 as well. Originally we had handled this by excluding
    2.13 from requirements. With this we should be able to removing
    the exclusion for 2.13 from global requirements.

    Change-Id: Ie047f7201d8e6a9a9641000d387c4312506f49b1
    Closes-Bug: #1239220

Changed in nova:
status: In Progress → Fix Committed
tags: added: grizzly-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/51709

Revision history for this message
Adam Gandelman (gandelman-a) wrote :

This fix here is not sufficient, opened https://bugs.launchpad.net/nova/+bug/1239890 to track

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/51760

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/51760
Committed: http://github.com/openstack/nova/commit/0409a098de02407e8229183ee55f11252c0a3cf4
Submitter: Jenkins
Branch: stable/grizzly

commit 0409a098de02407e8229183ee55f11252c0a3cf4
Author: Adam Gandelman <email address hidden>
Date: Mon Oct 14 18:01:15 2013 -0700

    Further harden boto version checking in EC2 tests

    Use pkg_resources to determine correct boto interface
    to use in API tests. stable/grizzly version.

    Fixes Bug #1239220

    Change-Id: I455ce5f2aabfad7178be361844c6b9b7b0d9c946

tags: added: in-stable-grizzly
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/65975

Alan Pevec (apevec)
tags: removed: grizzly-backport-potential in-stable-grizzly
Alan Pevec (apevec)
tags: removed: havana-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/havana)

Reviewed: https://review.openstack.org/65975
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=03f7ee05081873b904db2bd7369ccf511b8ed8a9
Submitter: Jenkins
Branch: stable/havana

commit 03f7ee05081873b904db2bd7369ccf511b8ed8a9
Author: Adam Gandelman <email address hidden>
Date: Mon Oct 14 18:01:15 2013 -0700

    Further harden boto version checking in EC2 tests

    Use pkg_resources to determine correct boto interface
    to use in API tests. stable/havana version.

    Fixes Bug #1239220

    Rebased-By: Dirk Mueller <email address hidden>

    Change-Id: I455ce5f2aabfad7178be361844c6b9b7b0d9c946

Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.