Hyper-V fails to spawn snapshots

[Lucian Petrut]

Creating a snapshot of an instance and then trying to boot from it will result the following Hyper-V exception: "HyperVException: WMI job failed with status 10". Here is the trace: http://paste.openstack.org/show/47904/ .

The ideea is that Hyper-V fails to expand the image, as it gets the request to resize it to it's actual size, which leads to an error.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/50396

[Matt Riedemann (mriedem)]

Patch is here: https://review.openstack.org/#/c/50439/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/50439
Committed: http://github.com/openstack/nova/commit/efdca8eeaffe6e63d57243147658f4691da3d89e
Submitter: Jenkins
Branch: master

commit efdca8eeaffe6e63d57243147658f4691da3d89e
Author: Petrut Lucian <email address hidden>
Date: Tue Oct 8 21:28:02 2013 +0300

    Fixes Hyper-V snapshot spawning issue

    In Hyper-V, snapshoting an instance and then spawning a new
    one using the resulted snapshot image with the same flavor,
    will result an Hyper-V Exception.

    Hyper-V will get the request to resize the base image to it's
    actual size, leading to an error.

    The reason is that the logic of the resize_vhd method has been
    changed, as it is meant to resize images to the flavor size minus
    the image metadata size, thus it's maximum internal size. For this
    reason, the way to decide whether the root image should be resized
    or not must also be changed.

    So, instead of comparing the root image and base image sizes,
    we should compare their maximum internal sizes.

    Closes-Bug: #1234759

    Change-Id: I83d2df76b726d705cedc52a8309a2be7037d6a79

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/53404

[Xiaopei Liu (liuxpei)]

I applyed the fix in https://review.openstack.org/53404 in my environment, this time can spawn snapshots on Hyper-V using dynamic VHDs.

[Yang Yu (yuyangbj)]

It is curious, I see the bug has been closed by review 50439, why the code review https://review.openstack.org/53404 is still working on this issue?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/53404
Committed: http://github.com/openstack/nova/commit/751b7ecb58cb16964509f1d9a30eacadacfdf253
Submitter: Jenkins
Branch: stable/havana

commit 751b7ecb58cb16964509f1d9a30eacadacfdf253
Author: Petrut Lucian <email address hidden>
Date: Tue Oct 8 21:28:02 2013 +0300

    Fixes Hyper-V snapshot spawning issue

    In Hyper-V, snapshoting an instance and then spawning a new
    one using the resulted snapshot image with the same flavor,
    will result an Hyper-V Exception.

    Hyper-V will get the request to resize the base image to it's
    actual size, leading to an error.

    The reason is that the logic of the resize_vhd method has been
    changed, as it is meant to resize images to the flavor size minus
    the image metadata size, thus it's maximum internal size. For this
    reason, the way to decide whether the root image should be resized
    or not must also be changed.

    So, instead of comparing the root image and base image sizes,
    we should compare their maximum internal sizes.

    Closes-Bug: #1234759

    Change-Id: I83d2df76b726d705cedc52a8309a2be7037d6a79
    (cherry picked from commit efdca8eeaffe6e63d57243147658f4691da3d89e)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/58351