VHD format check is not properly performed for fixed disks in the Hyper-V driver

Bug #1233853 reported by Alessandro Pilotti on 2013-10-01
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
High
Alessandro Pilotti
Havana
Undecided
Lucian Petrut

Bug Description

By the VHD specs, fixed disks don't have a copy of the footer at the beginning of the file:

http://download.microsoft.com/download/f/f/e/ffef50a5-07dd-4cf8-aaa3-442c0673a029/Virtual%20Hard%20Disk%20Format%20Spec_10_18_06.doc

tags: added: hyper-v
tags: added: havana-rc-potential
summary: - VHD format footer copy is not created properly by the Microsoft VHDTool
- utility
+ VHD format check is not properly performed for fixed disks in the
+ Hyper-V driver
description: updated
Changed in nova:
assignee: nobody → Alessandro Pilotti (alexpilotti)
Changed in nova:
status: New → In Progress
Changed in nova:
importance: Undecided → High
Thierry Carrez (ttx) on 2013-10-14
tags: added: havana-backport-potential
removed: havana-rc-potential

Reviewed: https://review.openstack.org/49269
Committed: http://github.com/openstack/nova/commit/fdc5a57d03b9a53981dc0e1623091980570456eb
Submitter: Jenkins
Branch: master

commit fdc5a57d03b9a53981dc0e1623091980570456eb
Author: Alessandro Pilotti <email address hidden>
Date: Wed Oct 2 00:39:09 2013 +0300

    Fixes Hyper-V issue with VHD file format

    The VHD format cookie signature needs to be checked in the footer
    instead of the header as fixed format VHDs don't have a copy of the
    footer at the beginning of the file.

    Fixes bug: #1233853

    Change-Id: Ibe44f0d895cde2edbc03dcd6ecebac24b0936660

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx) on 2013-12-04
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in nova:
milestone: icehouse-1 → 2014.1

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/110700

Change abandoned by Petrut Lucian (<email address hidden>) on branch: stable/havana
Review: https://review.openstack.org/83360

Reviewed: https://review.openstack.org/110700
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4b38f3e59bd7ead2cd279563164a3a2a7989b6b4
Submitter: Jenkins
Branch: stable/havana

commit 4b38f3e59bd7ead2cd279563164a3a2a7989b6b4
Author: Alessandro Pilotti <email address hidden>
Date: Wed Oct 2 00:39:09 2013 +0300

    Fixes Hyper-V issue with VHD file format

    The VHD format cookie signature needs to be checked in the footer
    instead of the header as fixed format VHDs don't have a copy of the
    footer at the beginning of the file.

    Fixes bug: #1233853

    (cherry-picked from commit fdc5a57d03b9a53981dc0e1623091980570456eb)

    Conflicts:

     nova/tests/virt/hyperv/test_vhdutils.py

    Change-Id: Ibe44f0d895cde2edbc03dcd6ecebac24b0936660

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers