some API exception responses are not translated

Bug #1225226 reported by Mathew Odden on 2013-09-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Low
Mathew Odden

Bug Description

There are some exception messages that are not being translated because they are caught and modified by the FaultWrapper
middleware class in the nova API. An example of this is the FloatingIpPoolNotFound exception from the neutron network API class.

Normally, any wsgi.Fault object would be translated, but FaultWrapper turns the exceptions into strings before we get a chance to translate it later.

Tags: api Edit Tag help
Mathew Odden (locke105) on 2013-09-13
tags: added: api

Fix proposed to branch: master
Review: https://review.openstack.org/46585

Changed in nova:
assignee: nobody → Mathew Odden (locke105)
status: New → In Progress
Changed in nova:
milestone: none → havana-rc1
importance: Undecided → Low

Reviewed: https://review.openstack.org/46585
Committed: http://github.com/openstack/nova/commit/c441af49814a57fdcc5482746bebbb6b80e46cd5
Submitter: Jenkins
Branch: master

commit c441af49814a57fdcc5482746bebbb6b80e46cd5
Author: Matt Odden <email address hidden>
Date: Fri Sep 13 09:50:18 2013 +0000

    Translate more REST API error messages

    There were a few exception messages that were not being
    translated because they were being wrapped and modified
    before being turned into wsgi.Fault objects by
    FaultWrapper. This adds some translation handling to
    the FaultWrapper so we can get these messages localized
    to the client's language specified in the Accept-Language
    header.

    Additionally adds a test to verfiy FaultWrapper is
    translating any exception messages that can be.

    fixes bug 1225226

    Change-Id: I3847cff0ac4b37f57eb04b27150c4e0d1ea23f29

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-10-03
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in nova:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers