Quota check for injected_file_contents does not consider base64 encoding

[Phil Day]

File content to be injected as part of instance creation is constrained by the injected_file_content_bytes quota, which is checked by _check_injected_file_quota() in compute/api.py.

However the contents has to be base64 encoded, its encoded in the client and decoded in compute/manager.py. The quota check however is performed against the encoded contents, and so fails when it should pass if the contents is very close to the quota limit

[Michael Still (mikal)]

I don't think you're correct here. The quota relates to the size of the database column IIRC. That means we can't be lenient here -- we need to enforce a maximum size for the b64 data.

[Phil Day (philip-day)]

Hi Michael - User Data is stored in the database - this is about injected files which are not stored in the DB, the content is just passed into the API, across to the manager as part of the create message, and then injected. It's never persisted in Nova itself.

 So I don't think your concern is valid in this case. (That we have sooo many different ways of getting "metadata" into an instance is another story of course)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/65633

[Joe Gordon (jogo)]

moved to Opinion based on the discussion on the abandoned patch