keymgr code references code in nova tests dir
Bug #1224526 reported by
Dan Prince
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
High
|
Dan Prince | ||
Bug Description
The latest Nova Havana code for keymgr references code imports directly from nova.tests:
See this line in keymgr/
from nova.tests.keymgr import single_key_mgr
We should not be importing code from the nova tests tree.
| Changed in nova: | |
| assignee: | nobody → Dan Prince (dan-prince) |
| status: | New → In Progress |
| Changed in nova: | |
| importance: | Undecided → High |
| milestone: | none → havana-rc1 |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to nova (master) | #1 |
| Changed in nova: | |
| status: | In Progress → Fix Committed |
| Changed in nova: | |
| status: | Fix Committed → Fix Released |
| Changed in nova: | |
| milestone: | havana-rc1 → 2013.2 |
To post a comment you must log in.
Reviewed: https:/
Committed: http://
Submitter: Jenkins
Branch: master
commit a0d785868c859fc
Author: Dan Prince <email address hidden>
Date: Thu Sep 12 11:14:30 2013 -0400
Move required keymgr classes out of nova/tests
Currently the Nova default keymgr implementation tries to
import classes from nova/tests. This could be a very bad
thing for production deployments which may not include
code from nova/tests.
This change moves two required modules (single_key_mgr and
mock_key_mgr) into the nova/keymgr tree.
Fixes bug: #1224526
Change-Id: I683b0245ab6b6a