run_instance() doesn't properly handle instances being deleting

[Hans Lindgren]

The UnexpectedTaskStateError that this currently results in should be caught and handled correctly to avoid unnecessary tracebacks in the compute log.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/46062

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/48932

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/48932
Committed: http://github.com/openstack/nova/commit/3a6fff04cb9b528182dac227469b53d067ad0bf3
Submitter: Jenkins
Branch: master

commit 3a6fff04cb9b528182dac227469b53d067ad0bf3
Author: Hans Lindgren <email address hidden>
Date: Wed Sep 11 14:17:57 2013 +0200

    Refactor UnexpectedTaskStateError for handling of deleting instances

    To avoid having to repeatedly unfold UnexpectedTaskStateErrors and
    do seperate handling of the 'deleting' task state from other states,
    everywhere this exception is handled, introduce a separate exception
    UnexpectedDeletingTaskStateError that derives from the above.

    This way, most handling of InstanceNotFound to handle instances gone
    during some action can be made to also include this new exception.

    Change-Id: Ia833c2b2361f32c7e33c84ec14d3af6231119a99
    Related-Bug: #1223843

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/46062
Committed: http://github.com/openstack/nova/commit/64aa897c8a2408093e277972f1e702e1a4287db2
Submitter: Jenkins
Branch: master

commit 64aa897c8a2408093e277972f1e702e1a4287db2
Author: Hans Lindgren <email address hidden>
Date: Mon Sep 30 15:15:08 2013 +0200

    Catch exception while building due to instance being deleted

    In run_instance() a instance_update() call in _start_building() can
    result in a UnexpectedDeletingTaskStateError if the instance gets
    deleted while being built.Since this is an expected situation, we
    don't want this exception written in the logs or worse, the instance
    be set to error state. Instead catch this and raise a proper
    BuildAbortException that gets handled above this call.

    Change-Id: Ib9d3dd22b33b104f1593d534876a5387df81d11c
    Closes-Bug: #1223843