OpenStack Compute (nova)

  1. Bug #1221190
  2. Comment #57

Comment 57 for bug 1221190

Revision history for this message
Andrew Laski (alaski) wrote : Re: Image format not enforced when using rescue

The fix seems sound and incorporates the feedback from Nikola and Daniel. I have a minor issue with one part but overall the fix is good.

The resolve_driver_format method works as if there could be multiple lines within a disk.info file. Since the file is now per instance I don't see why it would need to be opened in append mode, or need to iterate over multiple lines in the file. But this is cleanup and not relevant to the security fix aspect of the patch.