VMware: unable to access VNC console if password is not configured

[Gary Kotton]

If the vnc_password is not configured the the user is unable to access the VNC console. Enable no password access to the VNC console.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/43268

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/43876

[Russell Bryant (russellb)]

I think this is probably Medium instead of Critical.

"Medium if the bug prevents a secondary feature from working properly"

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/43268
Committed: http://github.com/openstack/nova/commit/2116d1033e1d87e64f2cc80784711467d89cc4aa
Submitter: Jenkins
Branch: master

commit 2116d1033e1d87e64f2cc80784711467d89cc4aa
Author: Gary Kotton <email address hidden>
Date: Thu Aug 22 03:29:30 2013 -0700

    VMware: enable VNC access without user having to enter password

    When the vnc_password was not configured in the 'vmware' section
    the user was unable to access the VNC console. The user would be
    requested to enter a password but all attempts would fail.

    The 'vnc_password' was added as a workaround to the problem above.

    The fix ensures that the VMware driver behaves like all of the other
    virt drivers when it comes to the VNC access, that is, the user will
    not have to enter a password.

    The password support will be deprecated and removed in the next
    version.

    Fixes bug: 1215352

    Change-Id: I728861b8965ee3d3b8444a0440ddd0a8e5bb9021