fixed ips and floating ips can't be synced properly

[Liyingjun]

fixed ips and floating ips can't be synced properly because they're tracked per user in the quota table but they're not tied to a user so it's not feasible to grab a count of how many are being used by any particular user. So the quota_usages table can get into a bad state if it sync with user level..

I think we could make the user_id column=NULL when creating the quota usage and reservation, so the usages for fixed_ips and floating_ips will be synced within the project.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/42966

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/42966
Committed: http://github.com/openstack/nova/commit/5a8363adacec44e84a4f6d6e4fa24680b22072eb
Submitter: Jenkins
Branch: master

commit 5a8363adacec44e84a4f6d6e4fa24680b22072eb
Author: liyingjun <email address hidden>
Date: Wed Aug 21 02:26:40 2013 +0800

    Fixes sync issue for user level resources

    fixed/floating ips and networks can't be synced properly because they're
    tracked per user in the quota table but they're not tied to a user so
    it's not feasible to grab a count of how many are being used by any
    particular user. So the quota_usages table can get into a bad state if
    it sync with user level.
    Sync these resources with project level, and set quota with project
    level to solve the problem.

    Fixes bug 1214523

    Change-Id: Icd94e95fb706ee90e0737e85cfa50f05ff3c0ff8

[Liyingjun (liyingjun)]

There is still an additional bug related.
In the case, if a normal user created a fixed_ip/floating_ip, then the fixed_ip/floating_ip is deleted by admin, a new reservation/usage record will be created in the db, and it should be the right case that the usage for fixed_ip/floating_ip of the user decreased.
See exactly: https://github.com/openstack/nova/blob/master/nova/network/floating_ips.py#L277, https://github.com/openstack/nova/blob/master/nova/network/floating_ips.py#L289,
https://github.com/openstack/nova/blob/master/nova/network/manager.py#L869,
https://github.com/openstack/nova/blob/master/nova/network/manager.py#L939

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/43583