Rescue operation should honor the enable_instance_password conf value

Bug #1213866 reported by Phil Day
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
GuoHui Liu

Bug Description

Currently the rescue operation (enabled by the os-rescue) extension always returns a generated (or user supplied) password, although not all hypervisors support password injection.

For server create and rebuild operations the configuration option "enable_instance_password=False" can be used to suppress returning a meaningless and confusing password, and the rescue operation should also honor this setting

Tags: api compute
GuoHui Liu (guohliu)
Changed in nova:
assignee: nobody → GuoHui LIu (guohliu)
tags: added: compute
Changed in nova:
status: New → Confirmed
importance: Undecided → Medium
tags: added: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/48196

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/48196
Committed: http://github.com/openstack/nova/commit/a19d72b0eacbc96236cac0e9306dae0de7c7cfc1
Submitter: Jenkins
Branch: master

commit a19d72b0eacbc96236cac0e9306dae0de7c7cfc1
Author: guohliu <email address hidden>
Date: Wed Sep 25 15:51:00 2013 +0800

    Fixes rescue doesn't honor enable password conf for v3

    The rescue api should honor enable_instance_password conf
    setting just like server creation and rebuild api does,
    enables this flag will returning the instance password from
    server API call rescue, If the hypervisor does not support
    password injection then the password returned will not be
    correct, this patch just fixes v3 rescue api, since change
    return value of v2 could potentially break apps which depend
    on this being returned.

    DocImpact
    Closes-bug #1213866

    Change-Id: Ie8422979940bbde8c5749fcd3d6c735e88f78c6a

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.