Flavor Extra Specs should check Metadata Items Quota

[Rohit Karajgi]

The flavor extra specs extension does not actually adhere to any quota restrictions during create.
The API handles the MetadataLimitExceeded exception
(see https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/contrib/flavorextraspecs.py#L76)
, but it looks like this exception would never get raised.

By default the Metadata Items quota for a tenant is 128. With the current code, more than 128 flavor extra spec items can be created.
Either of the two should be done:

1. Enforce the metadata limit (use _check_metadata_properties_quota() just as used in instance metadata) , Or,
2. If this limit should not be enforced, then the exception handling code should be removed.

[Joe Gordon (jogo)]

git grep shows:
nova/compute/api.py: raise exception.MetadataLimitExceeded(allowed=...

So is this still valid?

[Tushar Patil (tpatil)]

Joe: The above metadata limit check is implemented for instances not for flavors. In the current code, I can add any number of metadata items to any flavor. I think this should be restricted to certain limit similar to instances.

[Jon Grimm (jgrimm)]

FWIW, the exception handling has been removed,

https://github.com/openstack/nova/commit/cdae1c4fec1ddfa7e5939e8e23ff916bf7c78dea

, whether quota adherence is desirable is a good question.

[Christopher Yeoh (cyeoh-0)]

It's an admin api so I don't think we need to quota restrict it.