when using memcache, nova host-list cause api exception

[Yaguang Tang]

nova host-list when using memcache

2013-08-14 09:18:57.245 TRACE nova.api.openstack File "/opt/stack/nova/nova/api/openstack/compute/contrib/hosts.py", line 143, in index
2013-08-14 09:18:57.245 TRACE nova.api.openstack set_zones=True)
2013-08-14 09:18:57.245 TRACE nova.api.openstack File "/opt/stack/nova/nova/compute/api.py", line 2900, in service_get_all
2013-08-14 09:18:57.245 TRACE nova.api.openstack services)
2013-08-14 09:18:57.245 TRACE nova.api.openstack File "/opt/stack/nova/nova/availability_zones.py", line 77, in set_availability_zones
2013-08-14 09:18:57.245 TRACE nova.api.openstack cache.delete(cache_key)
2013-08-14 09:18:57.245 TRACE nova.api.openstack File "/usr/lib/python2.7/dist-packages/memcache.py", line 421, in delete
2013-08-14 09:18:57.245 TRACE nova.api.openstack self.check_key(key)
2013-08-14 09:18:57.245 TRACE nova.api.openstack File "/usr/lib/python2.7/dist-packages/memcache.py", line 1014, in check_key
2013-08-14 09:18:57.245 TRACE nova.api.openstack "Keys must be str()'s, not unicode. Convert your unicode "
2013-08-14 09:18:57.245 TRACE nova.api.openstack MemcachedStringEncodingError: Keys must be str()'s, not unicode. Convert your unicode strings using mystring.encode(charset)!
2013-08-14 09:18:57.245 TRACE nova.api.openstack

fix should be something like this

diff --git a/nova/availability_zones.py b/nova/availability_zones.py
index d627fa0..869ad87 100644
--- a/nova/availability_zones.py
+++ b/nova/availability_zones.py
@@ -56,7 +56,7 @@ def _reset_cache():

 def _make_cache_key(host):
- return "azcache-%s" % host
+ return "azcache-%s" % str(host)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/41873

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/41873
Committed: http://github.com/openstack/nova/commit/6e047e0b87d2caffe9d60c305f7ba4dcb17d8167
Submitter: Jenkins
Branch: master

commit 6e047e0b87d2caffe9d60c305f7ba4dcb17d8167
Author: Yaguang Tang <email address hidden>
Date: Wed Aug 14 17:23:12 2013 +0800

    Fix unicode key of azcache can't be stored to memcache

    The memcache library we are using assumes all strings passed to
    it are plain ascii, so we need to convert unicode to string.

    Fix bug #1212164

    Change-Id: Ibf36e6b096893cb9f056371bb43cbb441cae6e32