Don't need to init testr in run_tests.sh

Bug #1211098 reported by Kui Shi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Kui Shi

Bug Description

In run_tests.sh, function init_testr will initialize testr if the directory .testrepository is not existed. Actually, testr will do the check before run the test:

In Python package testrepository, setuptools_command.py:Testr.run

 68 def run(self):
 69 """Set up testr repo, then run testr"""
 70 if not os.path.isdir(".testrepository"):
 71 self._run_testr("init")

So, init_testr can be removed safely.

Kui Shi (skuicloud)
Changed in nova:
assignee: nobody → Kui Shi (skuicloud)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/41327

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/41327
Committed: http://github.com/openstack/nova/commit/ba7a070ee7ce7c52659451a227df3f91608b1416
Submitter: Jenkins
Branch: master

commit ba7a070ee7ce7c52659451a227df3f91608b1416
Author: Kui Shi <email address hidden>
Date: Sun Aug 11 20:16:47 2013 +0800

    Don't need to init testr in run_tests.sh

    In run_tests.sh, function init_testr will initialize testr if the
    directory .testrepository is not existed. Actually, testr will do
    the check before run the test:

    In Python package testrepository, setuptools_command.py:Testr.run

    68 def run(self):
    69 """Set up testr repo, then run testr"""
    70 if not os.path.isdir(".testrepository"):
    71 self._run_testr("init")

    So, init_testr can be removed safely.

    Fixes Bug #1211098

    Change-Id: I4bd2ef3dc107281892732efced268eb3b7c90cbb

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.