| 2013-07-30 07:45:55 |
Rohan |
bug |
|
|
added bug |
| 2013-07-30 07:46:17 |
Rohan |
nova: assignee |
|
Rohan (kanaderohan) |
|
| 2013-07-30 08:58:36 |
Tiantian Gao |
nova: status |
New |
Confirmed |
|
| 2013-07-30 08:59:51 |
Tiantian Gao |
tags |
ntt |
api ntt |
|
| 2013-08-01 15:54:54 |
Rohit Karajgi |
summary |
Leading and trailing whitespaces in Flavor name |
Name validations for compute resources |
|
| 2013-08-01 15:54:56 |
Rohit Karajgi |
description |
Branch: master
Commit id : 6a3f5fd6cca81d73df9dd11f722a88752bdb3164
I am able to create flavor with name which contains leading and trailing whitespaces, I am also able to create flavor with name which contains only whitespaces.
This should not be allowed.
Request data:
{
"flavor": {
"name": " aaa ",
"ram": 1024,
"vcpus": 2,
"disk": 10,
"id": "10w11"
}
}
and
{
"flavor": {
"name": " ",
"ram": 1024,
"vcpus": 2,
"disk": 10,
"id": "10w11"
}
}
Detailed request and response
http://paste.openstack.org/show/42581/ |
There is no consistent validation for the 'name' parameter across compute resources. The following characters need to be validated in the input:
1. One more whitespaces (like ' ' or ' ') -
2. Leading or trailing whitespaces (like ' test123 ')
Currently flavor name, volume name, role name, group name, security group name and keypair name accept input in each of the two cases (no validation).
Adding the two cases above to name parameter validation would be useful.
It makes sense to move this validation code to a common utility that can be used across all Create resource methods.
Although the 'name' is not as significant the resource's ID, it does act as a label for the resource and should be validated properly.
Refer: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3086 _validate_new_keypair() can be moved to a common utility to provide 'name' field validations. |
|
| 2013-08-02 09:24:16 |
Rohit Karajgi |
description |
There is no consistent validation for the 'name' parameter across compute resources. The following characters need to be validated in the input:
1. One more whitespaces (like ' ' or ' ') -
2. Leading or trailing whitespaces (like ' test123 ')
Currently flavor name, volume name, role name, group name, security group name and keypair name accept input in each of the two cases (no validation).
Adding the two cases above to name parameter validation would be useful.
It makes sense to move this validation code to a common utility that can be used across all Create resource methods.
Although the 'name' is not as significant the resource's ID, it does act as a label for the resource and should be validated properly.
Refer: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3086 _validate_new_keypair() can be moved to a common utility to provide 'name' field validations. |
There is no consistent validation for the 'name' parameter across compute resources. The following characters need to be validated in the input:
1. One more whitespaces (like ' ' or ' ') -
2. Leading or trailing whitespaces (like ' test123 ')
Currently flavor name, volume name, role name, group name, security group name and keypair name accept input in each of the two cases (no validation).
Adding the two cases above to name parameter validation would be useful.
It makes sense to move this validation code to a common utility that can be used across all Create resource methods.
Although the 'name' is not as significant the resource's ID, it does act as a label for the resource and should be validated properly.
For example, from the dasbhboard, a role with a blank name, i.e single whitespace string like ' ' can be created. This get's stored in the keystone db as NULL and appears in the dashboard roles drop down during Create User as None. This behavior should be fixed.
Refer: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3086 _validate_new_keypair() can be moved to a common utility to provide 'name' field validations. |
|
| 2013-08-02 09:25:34 |
Rohit Karajgi |
bug task added |
|
keystone |
|
| 2013-08-02 09:57:39 |
Rohan |
keystone: assignee |
|
Rohan (kanaderohan) |
|
| 2013-08-02 10:00:25 |
Rohit Karajgi |
affects |
nova |
cinder |
|
| 2013-08-02 10:02:25 |
Rohit Karajgi |
bug task added |
|
nova |
|
| 2013-08-02 10:02:53 |
Rohit Karajgi |
nova: status |
New |
Confirmed |
|
| 2013-08-02 10:03:10 |
Rohan |
nova: assignee |
|
Rohan (kanaderohan) |
|
| 2013-08-03 05:45:25 |
Xiaoxi Chen |
bug task added |
|
oslo |
|
| 2013-08-03 14:17:07 |
Rohan |
oslo: assignee |
|
Rohan (kanaderohan) |
|
| 2013-08-12 18:11:25 |
Dolph Mathews |
keystone: status |
New |
Invalid |
|
| 2013-08-12 18:11:25 |
Dolph Mathews |
keystone: assignee |
Rohan (kanaderohan) |
|
|
| 2013-08-13 11:13:20 |
Rohit Karajgi |
attachment added |
|
blank role name https://bugs.launchpad.net/nova/+bug/1206396/+attachment/3770986/+files/role_whitespace.png |
|
| 2013-08-13 11:14:35 |
Rohit Karajgi |
keystone: status |
Invalid |
New |
|
| 2013-08-21 17:25:48 |
Ben Nemec |
oslo: status |
New |
Invalid |
|
| 2013-09-16 15:41:02 |
Dolph Mathews |
keystone: importance |
Undecided |
Wishlist |
|
| 2013-09-25 08:22:17 |
Aswad Rangnekar |
cinder: assignee |
Rohan (kanaderohan) |
Aswad Rangnekar (aswad-r) |
|
| 2013-09-25 08:22:25 |
Aswad Rangnekar |
keystone: assignee |
|
Aswad Rangnekar (aswad-r) |
|
| 2013-09-25 08:22:30 |
Aswad Rangnekar |
nova: assignee |
Rohan (kanaderohan) |
Aswad Rangnekar (aswad-r) |
|
| 2013-09-25 08:22:36 |
Aswad Rangnekar |
oslo: assignee |
Rohan (kanaderohan) |
Aswad Rangnekar (aswad-r) |
|
| 2014-02-05 19:34:05 |
Dolph Mathews |
keystone: assignee |
Aswad Rangnekar (aswad-r) |
|
|
| 2014-02-05 19:46:06 |
Rohan |
keystone: assignee |
|
Rohan (kanaderohan) |
|
| 2014-09-18 23:36:41 |
Sean Dague |
nova: assignee |
Aswad Rangnekar (aswad-r) |
|
|
| 2014-09-18 23:39:02 |
Sean Dague |
nova: status |
Confirmed |
Opinion |
|
| 2014-09-21 06:12:01 |
Morgan Fainberg |
keystone: status |
New |
Confirmed |
|
| 2015-11-01 21:32:11 |
Sean McGinnis |
cinder: status |
Confirmed |
Invalid |
|
| 2015-11-30 07:05:17 |
Steve Martinelli |
keystone: status |
Confirmed |
Invalid |
|
