vmwareapi get_datastore_ref_and_name needs to be broken up into get_shared_datastores and get_local_datastores

[Shawn Hartsock]

in vm_util.py method "get_datastore_ref_and_name"

The method description """Get the datastore list and choose the first local storage.""" has the key word "and" which tends to indicate that there is a problem in a method's design. This should probably be the composition of two methods """Get the datastore list.""" and """choose the first local storage.""" in the least. At best, there should be a separate vSphere query to pull only the first local storage so that extra data is not pulled across the wire.

See:
https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vm_util.py#L670

[Gary Kotton (garyk)]

Is this still an issue? That is, there is the regular expression support and the selection of the DS with e most available memory...

[Shawn Hartsock (hartsock)]

This a complaint about bad design. The use of the word "and" in a method name should be a red flag. I currently think we should use a data structure representing lookup details for a datastore including its ref, name, and datacenter.