should not exclude plugins from flake8 tests

Bug #1197858 reported by John Garbutt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
John Garbutt

Bug Description

We have pep8 errors sneeking into all the plugins due to the plugins being excluded from pep8 checks.

Unfortunatly, this includes both:
/plugins/xenserver
and
/nova/api/openstack/compute/plugins

We want to exclude the top one, but not the bottom ones.

Changed in nova:
importance: Undecided → High
assignee: nobody → John Garbutt (johngarbutt)
status: New → Triaged
Changed in nova:
status: Triaged → In Progress
Revision history for this message
John Garbutt (johngarbutt) wrote :

We can't check the the xenserver plugins because they are run in python 2.4, and our flake8 settings enforce the python 2.4 incompatible:
N308 Python 3.x incompatible 'except x,y:' construct

description: updated
summary: - should not exclude plugins from pep8
+ should not exclude plugins from flake8 tests
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/35680

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/35680
Committed: http://github.com/openstack/nova/commit/707a7964f417e0df45223ccc2b40d42f944a947c
Submitter: Jenkins
Branch: master

commit 707a7964f417e0df45223ccc2b40d42f944a947c
Author: John Garbutt <email address hidden>
Date: Thu Jul 4 16:56:43 2013 +0100

    Ensure flake8 tests run on all api code

    We need to exclude the plugins/xenserver directory
    because the python2.4 code can't use as in except clauses.
    The existing exclude directory accidentally included some
    code in nova/api/openstack/compute/plugins and the related
    tests. This code is now included in the flake8 tests,
    and the current violations have been fixed up.

    Fixes bug 1197858

    Change-Id: Ib5f1b65d5d793f0f5854e898ca3ce751e43ef233

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.