Host is always set to None in get_instance_nw_info(...)

[David Scannell]

The the nova-network manager's method get_instance_nw_info(...) the host parameter get reset to None.

This causes the host to be interpreted as the host where the nova-network process is running instead of the host that is passed in (which is usually the host where the instance lives). One side affect of this change is that the address of the DHCP server for an instance can get assigned to a random host depending on which nova-network process handles the get_instance_nw_info(...) call instead of the host where the instance exists.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/32438
Committed: http://github.com/openstack/nova/commit/b0a2a2d29f24cea15d866f352d4beae5da965605
Submitter: Jenkins
Branch: master

commit b0a2a2d29f24cea15d866f352d4beae5da965605
Author: David Scannell <email address hidden>
Date: Mon Jun 10 13:04:55 2013 -0400

    Avoid redefining host to none in get_instance_nw_info(...)

    The host parameter is required and a part of the method signature.
    When it is redefined from kwargs.get('host') the supplied value
    gets redefined to None. This removes the redefinition and keeps the
    parameter value intact.

    Fixes bug #1194178

    Change-Id: I779cbce909935a4b794c16cefb0128f16f8563fb

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/36574

[Sam Morrison (sorrison)]

I think this is related to https://bugs.launchpad.net/nova/+bug/1092347

I tested this fix out but it still didn't fix it.

We have a hack which sets dhcp_servers = $my_ip and this works well when only have one network but won't work if you have multiple networks.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/36574
Committed: http://github.com/openstack/nova/commit/d35e7488aaf9b74b38c07639e2031fc95e3acb55
Submitter: Jenkins
Branch: stable/grizzly

commit d35e7488aaf9b74b38c07639e2031fc95e3acb55
Author: David Scannell <email address hidden>
Date: Mon Jun 10 13:04:55 2013 -0400

    Avoid redefining host to none in get_instance_nw_info(...)

    The host parameter is required and a part of the method signature.
    When it is redefined from kwargs.get('host') the supplied value
    gets redefined to None. This removes the redefinition and keeps the
    parameter value intact.

    Fixes bug #1194178

    Change-Id: I779cbce909935a4b794c16cefb0128f16f8563fb
    (cherry picked from commit b0a2a2d29f24cea15d866f352d4beae5da965605)