key_pairs name column should be not null in DB

Bug #1189981 reported by David Ripton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Kent Wang

Bug Description

mreidem mentioned this in IRC.

key_pairs.name is not forced to be non-null. But the API enforces that name is not allowed to be null. We should go ahead and add the constraint to the column.

Tags: db
David Ripton (dripton)
Changed in nova:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Boris Pavlovic (boris-42) wrote :

I think that we should wait with this change. Until we implement this BP:
https://blueprints.launchpad.net/nova/+spec/db-sync-models-with-migrations

Revision history for this message
Sean Dague (sdague) wrote :

Honestly, this seems like an actual integrity concern, I think it should be more than wishlist.

Changed in nova:
importance: Wishlist → Medium
Sean Dague (sdague)
Changed in nova:
assignee: David Ripton (dripton) → nobody
Kent Wang (k.wang)
Changed in nova:
assignee: nobody → Kent Wang (k.wang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/163230

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/163230
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=dd52617232c0915c85ca227e975c759c20e41b75
Submitter: Jenkins
Branch: master

commit dd52617232c0915c85ca227e975c759c20e41b75
Author: Kent Wang <email address hidden>
Date: Tue Mar 10 08:44:32 2015 -0700

    Adds Not Null constraint to KeyPair name

    Since the API enforces that name is not null, the database schema and
    model are now updated to enforce this.

    Change-Id: I1088cc79f4998d3b6609891adbb0479381297ec4
    Related-Bug: #1403544
    Closes-Bug: #1189981

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.