driver libvirt doesn't honor vif quota

Bug #1185030 reported by Sylvain Afchain
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Yassine
Grizzly
Fix Released
Medium
Mathieu Gagné

Bug Description

Driver libvirt does not seem to read the extra_specs field of flavors. Thus there is no bandwidth tag in the generated libvirt xml file.

# nova flavor-show m1.nano
+----------------------------+---------------------------------------------------------------------------------+
| Property | Value |
+----------------------------+---------------------------------------------------------------------------------+
| name | m1.nano |
| ram | 64 |
| OS-FLV-DISABLED:disabled | False |
| vcpus | 1 |
| extra_specs | {u'quota:vif_inbound_peak': u'102400', u'quota:vif_inbound_average': u'102400'} |
| swap | |
| os-flavor-access:is_public | True |
| rxtx_factor | 1.0 |
| OS-FLV-EXT-DATA:ephemeral | 0 |
| disk | 0 |
| id | 42 |
+----------------------------+---------------------------------------------------------------------------------+

# nova boot --flavor m1.nano --image 2f624a03-baf2-4a57-9a44-44357c178281 vm1
# cat /var/run/libvirt/qemu/instance-00000001.xml

...
      <interface type='bridge'>
        <mac address='fa:16:3e:59:f0:62'/>
        <source bridge='qbr634535f0-e8'/>
        <target dev='tap634535f0-e8'/>
        <model type='virtio'/>
        <driver name='qemu'/>
        <alias name='net0'/>
        <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
      </interface>
....

Changed in nova:
assignee: nobody → Sylvain Afchain (sylvain-afchain)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/30906

Changed in nova:
status: New → In Progress
Changed in nova:
assignee: Sylvain Afchain (sylvain-afchain) → nobody
Changed in nova:
assignee: nobody → Yassine (yassine-lamgarchal)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/32711

tags: added: grizzly-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/32711
Committed: http://github.com/openstack/nova/commit/08f8773b9a4fe7fea248b4501230ebd6e6ef2fde
Submitter: Jenkins
Branch: master

commit 08f8773b9a4fe7fea248b4501230ebd6e6ef2fde
Author: Yassine Lamgarchal <email address hidden>
Date: Mon Jun 10 14:47:57 2013 +0200

    Add inst_type parameter

    Add inst_type parameter in order to generate the bandwidth tag into
    the libvirt configuration.

    Change-Id: I63c1fb51ea637d461755b309c7464f4b4d49a4b2
    Fixes: bug #1185030

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/38402

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/38402
Committed: http://github.com/openstack/nova/commit/2c1061df8e4ac1a228d79b5ed9c331035fa08d72
Submitter: Jenkins
Branch: stable/grizzly

commit 2c1061df8e4ac1a228d79b5ed9c331035fa08d72
Author: Yassine Lamgarchal <email address hidden>
Date: Mon Jun 10 14:47:57 2013 +0200

    Add inst_type parameter

    Add inst_type parameter in order to generate the bandwidth tag into
    the libvirt configuration.

    Change-Id: I63c1fb51ea637d461755b309c7464f4b4d49a4b2
    Fixes: bug #1185030
    (cherry picked from commit 08f8773b9a4fe7fea248b4501230ebd6e6ef2fde)

Alan Pevec (apevec)
tags: removed: grizzly-backport-potential
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.