VMware drivers are no longer passing quantum port-id to vCenter

[dan wendlandt]

to work with quantuam, the vCenter driver passes an iface-id to vCenter.
I need to investigate this more. Its a one-line work around, but I need to do some more investigation to figure out what the "right" way to do the fix is.

[dan wendlandt (danwent)]

actually, the fix is quite simple. commit 70c659059b8fbef811ce79700aecb01c60242ebd broke this, but all we have to do is change one line to pass in vif['id'] rather than vif.get_meta('iface_id') which is never populated with anything useful.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/30545

[dan wendlandt (danwent)]

please set this to priority 'high'

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/30545
Committed: http://github.com/openstack/nova/commit/c028e54f6be75d1cd335550cf5291ddf94f973e3
Submitter: Jenkins
Branch: master

commit c028e54f6be75d1cd335550cf5291ddf94f973e3
Author: Dan Wendlandt <email address hidden>
Date: Sat May 25 14:22:23 2013 -0700

    correctly set iface-id in vmware driver

    bug 1183452

    Commit 70c659059b8fbef811ce79700aecb01c60242ebd updated the vmware
    driver to use the new vif model, but was incorrect in how it tried to
    grab the iface-id and set it in the vmx file spec. This patch fixes
    that issue and adds a check for this in the existing unit tests.

    Change-Id: I756539871d1844a828f9a0a295fc9fa3e59610f7

[Sina Sadeghi (sina-sa)]

Hi Dan,

I can confirm that the patch fixes the issue for us.

Thanks very much.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/33145

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/33145
Committed: http://github.com/openstack/nova/commit/4bb6263e91e27f6023ff05cf718a648d340a4143
Submitter: Jenkins
Branch: stable/grizzly

commit 4bb6263e91e27f6023ff05cf718a648d340a4143
Author: Dan Wendlandt <email address hidden>
Date: Sat May 25 14:22:23 2013 -0700

    correctly set iface-id in vmware driver

    bug 1183452

    Commit 70c659059b8fbef811ce79700aecb01c60242ebd updated the vmware
    driver to use the new vif model, but was incorrect in how it tried to
    grab the iface-id and set it in the vmx file spec. This patch fixes
    that issue and adds a check for this in the existing unit tests.

    Change-Id: I756539871d1844a828f9a0a295fc9fa3e59610f7
    (cherry picked from commit c028e54f6be75d1cd335550cf5291ddf94f973e3)