VNC console does not work with VCDriver

[dan wendlandt]

From testing, it seems like VNC consoles do not work with the VCDriver.

There are actually two issues, one a doc issue, one a code issue.

1) Doc issue:

For vSphere version 5+, you need to poke a hole in the ESX firewall to allow VNC traffic. See: http://www.virtuallyghetto.com/2012/01/using-vnc-client-to-connect-to-vms-in.html

2) Code issue:

It seems like VNC consoles works with the ESXDriver, was not updated for the VCDriver, as get_vnc_console returns CONF.vmwareapi_host_ip, which is the ESX host IP with the ESXDriver, but is the vCenter host IP with the VCDriver (https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vmops.py#L1105).

[Shawn Hartsock (hartsock)]

I'm working on a patch for this that changes the behavior of the driver for vCenter so that we end up talking to the correct IP.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/30036

[Shawn Hartsock (hartsock)]

Needs testing. Customer says this works but requires custom firewall rules on ESXi

[Shawn Hartsock (hartsock)]

I've pushed a patch with testing included.

[Shawn Hartsock (hartsock)]

This should be ready to go.

[Shawn Hartsock (hartsock)]

This is critical. System VNC fails without this patch. No work around available.

[Shawn Hartsock (hartsock)]

I will have to rebase and alter this code, the code-base has drifted underneath the patch and it is now not compatible with the driver.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/30036
Committed: http://github.com/openstack/nova/commit/271fc68c1852e3764b7c64d71cd28ac3f803ecba
Submitter: Jenkins
Branch: master

commit 271fc68c1852e3764b7c64d71cd28ac3f803ecba
Author: hartsocks <email address hidden>
Date: Tue May 21 20:38:28 2013 -0700

    VNC console does not work with VCDriver

    Introduces get_vnc_console_vcenter as a way to get
    a modified vnc_console object that connects to the
    ESXi host underneath vCenter control.

    * adds new fake classes for testing
    * documents classes, methods & API logic

    fixes bug: #1178369

    Change-Id: I48430cb9bc9615e02ca9af235f97853f3f0bdafd

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/38473

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/38473
Committed: http://github.com/openstack/nova/commit/1ef0d96be333688b6139168d196028f93bdc2381
Submitter: Jenkins
Branch: stable/grizzly

commit 1ef0d96be333688b6139168d196028f93bdc2381
Author: hartsocks <email address hidden>
Date: Tue May 21 20:38:28 2013 -0700

    VNC console does not work with VCDriver

    Introduces get_vnc_console_vcenter as a way to get
    a modified vnc_console object that connects to the
    ESXi host underneath vCenter control.

    * adds new fake classes for testing
    * documents classes, methods & API logic

    fixes bug: #1178369

    (cherry picked from commit 271fc68c1852e3764b7c64d71cd28ac3f803ecba)

    Conflicts:

     nova/virt/vmwareapi/fake.py

    Change-Id: I48430cb9bc9615e02ca9af235f97853f3f0bdafd