vmware driver should work without requiring patched wsdl

Bug #1171215 reported by dan wendlandt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Critical
Shawn Hartsock
Grizzly
Fix Released
Critical
Michal Jura

Bug Description

The current vmware driver requires the user to run tomcat on each nova-compute node to serve up a wsdl file, specified using the nova.conf option vmwareapi_wsdl_loc.

This is a workaround for a bug in the ESX 4.1 WSDL, but is not necessary for newer versions of ESX, including the current 5.0 and 5.1 . However, the current code ALWAYS requires the workaround.

We should change this so that the driver can be started without the vmwareapi_wsdl_loc option, and that the driver only errors out if the resulting connection is to an unfixed version of vCenter/ESX.

Should be a very simple change to the code, see: https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vim.py#L89

Tags: vmware
Revision history for this message
dan wendlandt (danwent) wrote :

working off of master

Changed in nova:
assignee: nobody → Shawn Hartsock (hartsock)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27463

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/27463
Committed: http://github.com/openstack/nova/commit/cf3cc74fcb65de3c59f98db001267e05ae405186
Submitter: Jenkins
Branch: master

commit cf3cc74fcb65de3c59f98db001267e05ae405186
Author: hartsocks <email address hidden>
Date: Mon Apr 29 20:41:17 2013 -0700

    fix broken WSDL logic

    vSphere driver incorrectly assumes that a WSDL is locally required.
    A local WSDL is only needed as a work-around for certain situations.

    Fixes bug 1171215

    Change-Id: Id8c5fc104c244ba768c58b97afdc26703c5c42ac

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/28240

Changed in nova:
importance: Undecided → Critical
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-1
status: Fix Committed → Fix Released
tags: added: grizzly-backport-potential
Tracy Jones (tjones-i)
tags: added: vmware-co-preferred
tags: removed: vmware-co-preferred
Tracy Jones (tjones-i)
Changed in openstack-vmwareapi-team:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/42627

Tracy Jones (tjones-i)
Changed in openstack-vmwareapi-team:
importance: Undecided → Critical
Changed in openstack-vmwareapi-team:
importance: Critical → Low
no longer affects: openstack-vmwareapi-team
Revision history for this message
Michal Jura (mjura) wrote :

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/#/c/42627/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/42619
Committed: http://github.com/openstack/nova/commit/2b646178e4ffb9972cb789d8a97b2e74f13c4b0c
Submitter: Jenkins
Branch: stable/grizzly

commit 2b646178e4ffb9972cb789d8a97b2e74f13c4b0c
Author: Michal Jura <email address hidden>
Date: Mon Aug 19 13:56:50 2013 +0200

    fix broken WSDL logic

    vSphere driver incorrectly assumes that a WSDL is locally required.
    A local WSDL is only needed as a work-around for certain situations.

    Fixes bug 1171215

    cherry picked from commit cf3cc74fcb65de3c59f98db001267e05ae405186

    Change-Id: I1cc81d96e263ad586b903a74dc9d5c602d475dc9

tags: added: in-stable-grizzly
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-1 → 2013.2
Alan Pevec (apevec)
tags: removed: grizzly-backport-potential in-stable-grizzly
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.