virtual_power_driver _mac_address is not set

Bug #1168574 reported by Devananda van der Veen on 2013-04-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Medium
Arata Notsu

Bug Description

After patch https://review.openstack.org/#/c/26078/ the baremetal virtual_power_driver has a problem, because it is still trying to read node['prov_mac_address'] which is no longer getting set.

nova/virt/baremetal/virtual_power_driver.py:
 79 def __init__(self, **kwargs):
 ...
 92 node = kwargs.pop('node', {})
 95 self._mac_address = node.get('prov_mac_address', "")
 96 self._mac_address = self._mac_address.replace(':', '')

Here is the error in n-cpu log:

  File "/opt/stack/venvs/nova/local/lib/python2.7/site-packages/nova/virt/baremetal/driver.py", line 361, in get_info
    pm = get_power_manager(node=node, instance=instance)
  File "/opt/stack/venvs/nova/local/lib/python2.7/site-packages/nova/virt/baremetal/driver.py", line 111, in get_power_manager
    return cls(**kwargs)
  File "/opt/stack/venvs/nova/local/lib/python2.7/site-packages/nova/virt/baremetal/virtual_power_driver.py", line 96, in __init__
    self._mac_address = self._mac_address.replace(':', '')
AttributeError: 'NoneType' object has no attribute 'replace'

Patch https://review.openstack.org/#/c/25881/ appears to address this.

Changed in nova:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Arata Notsu (arata776)
tags: added: baremetal

Reviewed: https://review.openstack.org/25881
Committed: http://github.com/openstack/nova/commit/708ff76a993e48e17025c5c2d5451e2e49adc696
Submitter: Jenkins
Branch: master

commit 708ff76a993e48e17025c5c2d5451e2e49adc696
Author: Arata Notsu <email address hidden>
Date: Mon Apr 15 20:27:03 2013 +0900

    baremetal: VirtualPowerDriver uses mac addresses in bm_interfaces

    After the change I6653829364b0a641442d45e766493180d6f2a880,
    bm_nodes.prov_mac_address is no longer set. However VPD still
    uses it. This patch changes VPD to use bm_interfaces.address
    instead of bm_nodes.prov_mac_address.

    Fixes bug 1168574.

    Change-Id: I2bab869b282958ee9fd0e4776928e56351018324

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-05-29
Changed in nova:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in nova:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers