OpenStack Compute (nova)

nova-manage uses nova.db.fixed_ip_get_all_by_instance_host, which no longer exists

Bug #1163660 reported by Michael Still
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Michael Still
OpenStack Compute (nova) 2013.2 "havana"
Grizzly
Fix Released
Medium
Michael Still
OpenStack Compute (nova) 2013.1.1

Bug Description

nova.db.fixed_ip_get_all_by_instance_host was removed in commit bb867ce3948ddc23cf928ca3dda100a1a977896a, but is still used in nova-manage. We need to fix this, as it affects listing Fixed Ips for a specific host.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25979

Changed in nova:
assignee: nobody → Michael Still (mikalstill)
status: Triaged → In Progress
Revision history for this message
Michael Still (mikal) wrote :

I missed that this was broken in _2012_ not 2013. Not critical.

Changed in nova:
importance: Critical → High
Thierry Carrez (ttx)
tags: added: grizzly-rc-potential
Vish Ishaya (vishvananda)
tags: added: grizzly-backport-potential
removed: grizzly-rc-potential
Vish Ishaya (vishvananda)
Changed in nova:
importance: High → Medium
Vish Ishaya (vishvananda)
tags: removed: grizzly-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/25979
Committed: http://github.com/openstack/nova/commit/5cced7a31482d014fe31f815f38fd00e079cc491
Submitter: Jenkins
Branch: master

commit 5cced7a31482d014fe31f815f38fd00e079cc491
Author: Michael Still <email address hidden>
Date: Wed Apr 3 16:22:12 2013 +1100

    Allow listing fixed_ips for a given compute host.

    nova.db.fixed_ip_get_all_by_instance_host was removed in commit
    bb867ce3948ddc23cf928ca3dda100a1a977896a, but was still used in
    nova-manage. This patch works around the removal of the foreign
    key that led to this method being removed.

    Resolves bug 1163660.

    Change-Id: Ieccd37c752e245558827615c098604d11ad3d945

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/27617

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/27617
Committed: http://github.com/openstack/nova/commit/141107fdbb8e8d17dd1e4112bdc064d33561dd2f
Submitter: Jenkins
Branch: stable/grizzly

commit 141107fdbb8e8d17dd1e4112bdc064d33561dd2f
Author: Michael Still <email address hidden>
Date: Wed Apr 3 16:22:12 2013 +1100

    Allow listing fixed_ips for a given compute host.

    nova.db.fixed_ip_get_all_by_instance_host was removed in commit
    bb867ce3948ddc23cf928ca3dda100a1a977896a, but was still used in
    nova-manage. This patch works around the removal of the foreign
    key that led to this method being removed.

    Resolves bug 1163660.

    Change-Id: Ieccd37c752e245558827615c098604d11ad3d945

Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.