required skip detach_volume in test_compute_cells

Bug #1157408 reported by Joe Gordon on 2013-03-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Medium
Chris Behrens

Bug Description

nova/tests/compute/test_compute_cells.py requires detach_volume tests to be skipped.

From the file: "This test is failing due to TypeError: detach_volume() takes exactly 3 arguments (4 given). detach_volume() takes exactly 3 arguments (4 given)"

https://github.com/openstack/nova/blob/master/nova/tests/compute/test_compute_cells.py#L190

tags: added: cells
Changed in nova:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → havana-1
Chris Behrens (cbehrens) wrote :

The problem is that trunk appears to have a couple of methods for volumes... but not the full volume code I have. There's some changes to the compute API calls for volume_detach that is needed.

Changed in nova:
assignee: nobody → Chris Behrens (cbehrens)
status: Confirmed → Triaged

Fix proposed to branch: master
Review: https://review.openstack.org/24921

Changed in nova:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/24921
Committed: http://github.com/openstack/nova/commit/26aa01094a79939320d58f2fe2d5731f169987b1
Submitter: Jenkins
Branch: master

commit 26aa01094a79939320d58f2fe2d5731f169987b1
Author: Chris Behrens <email address hidden>
Date: Wed Mar 20 18:13:05 2013 +0000

    Change arguments to volume_detach()

    Most compute API calls accept an instance object. To be compatible with
    cells, volume_detach() should as well. Also change it to accept the
    volume object, instead of just a volume ID. This lets us proxy the
    volume object to child cells a bit more easily.

    This removes 2 skipTests that we have related to volumes and cells.

    Fixes bug 1157408

    There was also a check that if instance_get_by_uuid() returned no
    instance, it VolumeUnattached should be raised. However, this check
    would never work as InstanceNotFound would have been raised. This
    patch also corrects that.

    Change-Id: Ide35ad5d8e147f6bd21b5840b901363dab0eae38

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-05-29
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in nova:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers