A default /24 netmask is used by dnsmasq instead of the configured netmasks (in netmasks table)

Bug #1154929 reported by David Hill
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
David Hill
Folsom
Fix Released
High
Vish Ishaya

Bug Description

When dnsmasq is leasing an IP, it does so with a hardcoded /24 netmask instead of the one configured in the netmasks table.

Windows 2008r2 seems a bit unpleased by this situation so here's a patch ...

Revision history for this message
David Hill (david-hill-ubisoft) wrote :
Revision history for this message
Chuck Short (zulcss) wrote :

Which version is this with?

Changed in nova:
status: New → Incomplete
Revision history for this message
David Hill (david-hill-ubisoft) wrote :

The patch is for the latest version (grizzly g3) but the bug is actually affecting:
 openstack-nova-2012.2.2-1.el6.noarch

Changed in nova:
status: Incomplete → New
Revision history for this message
Chuck Short (zulcss) wrote :

Thanks, please follow the following to submit the patch to Openstack.

Changed in nova:
status: New → Triaged
Revision history for this message
Chuck Short (zulcss) wrote :

Thanks, please follow the following to submit the patch to Openstack.https://wiki.openstack.org/wiki/Gerrit_Workflow

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25328

Changed in nova:
assignee: nobody → David Hill (david-hill-ubisoft)
status: Triaged → In Progress
Revision history for this message
David Hill (david-hill-ubisoft) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/25328
Committed: http://github.com/openstack/nova/commit/fb151b5e3704c9a293f10ba89abc14f83d803c24
Submitter: Jenkins
Branch: master

commit fb151b5e3704c9a293f10ba89abc14f83d803c24
Author: David Hill <email address hidden>
Date: Mon Mar 25 16:27:25 2013 -0400

    Adding netmask to dnsmasq argument --dhcp-range

    By default, dnsmasq will try to guess the proper subnet size but
    sometimes it will fail. This patch provides the network netmask
    to dnsmasq via the --dhcp-range argument.

    Fixes: bug #1154929

    Change-Id: I74d62c837b5310004b9151851697e3ea3b475f92

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → grizzly-rc2
importance: Undecided → High
tags: added: folsom-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25581

tags: removed: folsom-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/25587

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (milestone-proposed)

Reviewed: https://review.openstack.org/25581
Committed: http://github.com/openstack/nova/commit/34a321fc2e23186510a8850a7cbe3ece635856c8
Submitter: Jenkins
Branch: milestone-proposed

commit 34a321fc2e23186510a8850a7cbe3ece635856c8
Author: David Hill <email address hidden>
Date: Mon Mar 25 16:27:25 2013 -0400

    Adding netmask to dnsmasq argument --dhcp-range

    By default, dnsmasq will try to guess the proper subnet size but
    sometimes it will fail. This patch provides the network netmask
    to dnsmasq via the --dhcp-range argument.

    Fixes: bug #1154929

    Change-Id: I74d62c837b5310004b9151851697e3ea3b475f92
    (cherry picked from commit fb151b5e3704c9a293f10ba89abc14f83d803c24)

Changed in nova:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/folsom)

Reviewed: https://review.openstack.org/25587
Committed: http://github.com/openstack/nova/commit/c85683ef4bb402d103080bbcb2d70b23f9a5113e
Submitter: Jenkins
Branch: stable/folsom

commit c85683ef4bb402d103080bbcb2d70b23f9a5113e
Author: David Hill <email address hidden>
Date: Mon Mar 25 16:27:25 2013 -0400

    Adding netmask to dnsmasq argument --dhcp-range

    By default, dnsmasq will try to guess the proper subnet size but
    sometimes it will fail. This patch provides the network netmask
    to dnsmasq via the --dhcp-range argument.

    Fixes: bug #1154929

    Change-Id: I74d62c837b5310004b9151851697e3ea3b475f92
    (cherry picked from commit fb151b5e3704c9a293f10ba89abc14f83d803c24)

Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.