EC2 API does not support InstanceInstantiatedShutdownBehavior

[Burt Holzman]

The EC2 API allows the setting of the InstanceInstantiatedShutdownBehavior to either "stop" or "terminate".
This settings is ignored and all instances go to a stop state rather than termination.

From the comments, it looks like this was removed in I91845a64 -- maybe Vish can comment before I dive in?

[Vish Ishaya (vishvananda)]

I'm not opposed to this going back in, but it likely requires some tricky checks in sync_power_states to see if the instance should be deleted.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/38081

[Joe Gordon (jogo)]

previous patch was abandoned

[OpenStack Infra (hudson-openstack)]

Change abandoned by Burt Holzman (<email address hidden>) on branch: master
Review: https://review.openstack.org/106679
Reason: Whoops, missed the old change-id.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Burt Holzman (<email address hidden>) on branch: master
Review: https://review.openstack.org/106680
Reason: Whoops, missed the old change-id.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/106679
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7a1e50772154b0b0907592582b91eb89407dfb8b
Submitter: Jenkins
Branch: master

commit 7a1e50772154b0b0907592582b91eb89407dfb8b
Author: Burt Holzman <email address hidden>
Date: Fri Jul 11 16:11:00 2014 -0500

    Make nova-api use quotas object for reservations

    This makes nova-api use the quotas object for reservations;
    more work needs to be done to convert the rest.

    Partial-Bug: #1131395
    Change-Id: I3e4d233278966c79019235ac8836a825c46c27ea

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/38081
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6132f991bdc8515aa665db16fef260ff71a618e6
Submitter: Jenkins
Branch: master

commit 6132f991bdc8515aa665db16fef260ff71a618e6
Author: Burt Holzman <email address hidden>
Date: Fri Jul 11 16:31:57 2014 -0500

    Enable terminate for EC2 InstanceInitiatedShutdownBehavior

    The EC2 API supports an instance attribute called
    InstanceInitiatedShutdownBehavior (IISB) which can be set to
    'stop' or 'terminate' (default: 'stop'). When the instance
    initiates its own shutdown, this determines whether or not
    the instance hangs around in the Shutoff state or is
    terminated by the system.

    In nova, this is handled by the shutdown_terminate boolean.
    IISB = stop => shutdown_terminate = False
    IISB = terminate => shutdown_terminate = True

    sync_instance_power_state now invokes compute_api.delete if
    shutdown_terminate = True and we detect the instance power state
    has gone from Running to Shutdown.

    Closes-Bug: #1131395
    Change-Id: I284ae7a84384f19131703c4ad44e0e5f5b03f5d4