Some object comparsion syntax nits
Bug #1110973 reported by
Zhongyue Luo
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Zhongyue Luo |
Bug Description
There are some lines in nova where instead of "if X is not Y", it uses "if not X is Y"
Since "is not" seems to be the consensus and is more intuitive, object inequality evaluations should use "is not"
$ grep -R " not " nova | grep " is " | grep -E ":\W*if" | wc -lc
315 22423
$ grep -R " not " nova | grep " is " | grep -v " is not " | grep -E ":\W*if" | wc -lc
16 1301
Changed in nova: | |
milestone: | none → grizzly-3 |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | grizzly-3 → 2013.1 |
To post a comment you must log in.
Fix proposed to branch: master /review. openstack. org/20865
Review: https:/