Multiple security groups with same name can be created

Bug #1093458 reported by Unmesh Gurjar
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Roman Bogorodskiy

Bug Description

Branch: master

Steps to reproduce:
1. Create multiple security groups simultaneously, having the same name.
2. Observe the result for each.

Expected Behavior:
The first security group should be created and second must receive a HTTP 409 response with an appropriate message.

Actual Behavior:
Multiple security groups having same name get created.

Tags: ntt
Revision history for this message
Boris Pavlovic (boris-42) wrote :

We will be able to fix it only after bp/db-unique-keys will be implemented.

Changed in nova:
assignee: nobody → Boris Pavlovic (boris-42)
Changed in nova:
status: New → In Progress
Revision history for this message
Joe Gordon (jogo) wrote :

Since fixing this will require a DB migration, lets hold fixing this until Havana, and this will be marked as a known issue in Grizzly.

Changed in nova:
milestone: none → havana-1
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-1 → havana-2
Changed in nova:
assignee: Boris Pavlovic (boris-42) → Roman Bogorodskiy (novel)
Changed in nova:
assignee: Roman Bogorodskiy (novel) → Michael Still (mikalstill)
Changed in nova:
assignee: Michael Still (mikalstill) → Roman Bogorodskiy (novel)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/32886
Committed: http://github.com/openstack/nova/commit/231c97007c6290f22807c0d4a605d9d95d4eb3af
Submitter: Jenkins
Branch: master

commit 231c97007c6290f22807c0d4a605d9d95d4eb3af
Author: Roman Bogorodskiy <email address hidden>
Date: Thu Jun 13 07:41:51 2013 -0400

    Add unique constraint for security groups

    - Add unique constraint (project_id, name, deleted)
      for security_groups
    - Define new SecurityGroupExists exception
    - Drop security_group_exists() in favor of catching
      SecurityGroupExists exception for security_group_create()

    Fixes bug #1093458

    Blueprint: db-enforce-unique-keys

    Change-Id: Id9a1427587cc9250942d0abd9eafc69861352d9b

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.