xenapi finish_migration does not cleanup on failures

[Chris Behrens]

It doesn't look as though finish_migration() has any exception handling to cleanup VDIs and VM record if finishing of a migration fails. We should probably make it use the UndoManager like 'spawn' does... and somehow share code.

[John Garbutt (johngarbutt)]

This will be easier to deal with after the live-migrate and migrate refactor.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/38455

[John Garbutt (johngarbutt)]

Targeted, because other target bugs depend on this change.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/38455
Committed: http://github.com/openstack/nova/commit/ba0d007fb78bd1182c3c0b808dbd7ccc84640e80
Submitter: Jenkins
Branch: master

commit ba0d007fb78bd1182c3c0b808dbd7ccc84640e80
Author: John Garbutt <email address hidden>
Date: Wed Jul 24 13:15:03 2013 +0100

    xenapi: ensure finish_migration cleans on errors

    This change makes finish_migration share code with spawn.

    This fixes some inconsistencies, such as applying the security
    group filters during finish_migration.

    Fixes bug 1073303
    Fixes bug 1073306

    Change-Id: Ib4f2a96618692c141708535f9463c856f3395922